Skip to content

fix: update project link structure in ProjectCard component#536

Open
WalterBanda123 wants to merge 2 commits into
firstcontributions:mainfrom
WalterBanda123:fix/go-to-project-button-issue
Open

fix: update project link structure in ProjectCard component#536
WalterBanda123 wants to merge 2 commits into
firstcontributions:mainfrom
WalterBanda123:fix/go-to-project-button-issue

Conversation

@WalterBanda123
Copy link
Copy Markdown

This pull request updates the ProjectCard component to improve the structure and user experience of the project link section. The main changes include repositioning the project link.

UI and UX improvements:

@Esh07
Copy link
Copy Markdown

Esh07 commented Feb 24, 2026

Thank you for opening this PR.

This is a bug caused by nested <a> tags, which is against the HTML specification. The suggested solution doesn't cover the full picture because it ignores what is being rendered inside the child components. While wrapping it in another <a> tag might appear to work, it doesn't solve the root cause of the issue.

See the discussion here

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

I tested this locally. The overall direction of moving the project link to the CTA is good, and the built page no longer has nested anchors, but the branch still needs cleanup before merge.

Checks run:

  • pnpm build passes
  • generated dist/index.html has max anchor depth 1 / no nested anchors
  • blank-target link scan on the built page

Blockers / follow-ups:

  • git diff --check main...HEAD fails because src/components/ProjectCard.astro:17 has trailing whitespace.
  • The new target="_blank" project CTA is missing rel="noopener noreferrer". The existing issue links are also missing it, so the built-page scan found 153 blank-target anchors without rel.
  • Since ProjectList.astro still reads .Card-Real-Link.href, keeping that class on the new CTA works here, but it would be worth documenting that this selector is intentional so a later cleanup does not accidentally break filtered/search-rendered card URLs.

A newer focused version of this fix is in #605, which keeps the valid anchor structure and also handles the blank-target rel issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants