fix: update project link structure in ProjectCard component#536
Open
WalterBanda123 wants to merge 2 commits into
Open
fix: update project link structure in ProjectCard component#536WalterBanda123 wants to merge 2 commits into
WalterBanda123 wants to merge 2 commits into
Conversation
|
Thank you for opening this PR. This is a bug caused by nested See the discussion here |
|
I tested this locally. The overall direction of moving the project link to the CTA is good, and the built page no longer has nested anchors, but the branch still needs cleanup before merge. Checks run:
Blockers / follow-ups:
A newer focused version of this fix is in #605, which keeps the valid anchor structure and also handles the blank-target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
ProjectCardcomponent to improve the structure and user experience of the project link section. The main changes include repositioning the project link.UI and UX improvements:
<a class="Card-Real-Link">) to wrap only the "Go to Project" button instead of the entire card, improving accessibility and click behaviour.