Skip to content

fix:-fixed go to project button layout #541

Open
ApekshaRao27 wants to merge 2 commits into
firstcontributions:mainfrom
ApekshaRao27:ui-fix
Open

fix:-fixed go to project button layout #541
ApekshaRao27 wants to merge 2 commits into
firstcontributions:mainfrom
ApekshaRao27:ui-fix

Conversation

@ApekshaRao27
Copy link
Copy Markdown

fix:-fixed go to project button layout when navigating through open issues,without altering the existing styles.
Note: Contribution guide mentions Contributors.md, but the file does not exist in the repository.

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

I tested this locally. The branch builds and the generated page no longer has nested anchors, but it needs cleanup before merge.

Checks run:

  • pnpm build passes
  • generated dist/index.html has max anchor depth 1 / no nested anchors
  • blank-target link scan on the built page

Blockers / follow-ups:

  • git diff --check main...HEAD fails because src/components/ProjectCard.astro:45 has trailing whitespace.
  • Please remove the generated .astro/* files from the PR.
  • The new target="_blank" links are missing rel="noopener noreferrer"; the built-page scan found 313 blank-target anchors without rel, including both .Card-Real-Link and .Card-Link.
  • The CTA uses an inline style="text-decoration: none;"; this should live in the existing .Card-Link CSS instead.
  • src/styles/global.css adds a site-wide focus-visible rule, which may be useful, but it is unrelated to this card-link bug and should probably be a separate focused PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants