Skip to content

fix: resolve Astro tsconfig extends path#591

Open
TeamInfinixdevcom wants to merge 1 commit into
firstcontributions:mainfrom
TeamInfinixdevcom:add-project-list
Open

fix: resolve Astro tsconfig extends path#591
TeamInfinixdevcom wants to merge 1 commit into
firstcontributions:mainfrom
TeamInfinixdevcom:add-project-list

Conversation

@TeamInfinixdevcom
Copy link
Copy Markdown

This PR fixes a local TypeScript configuration issue that was showing false errors in the editor when trying to resolve Astro’s base config.

I updated the config reference so the project resolves correctly in this environment, then verified everything by installing dependencies and running the development server.

There are no functional or UI changes in this PR.
It only improves developer experience by removing misleading configuration errors.

Copilot AI review requested due to automatic review settings April 26, 2026 00:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

I checked this locally. pnpm build passes and git diff --check main...HEAD passes, but I am not sure this change should be merged as-is.

Astro’s TypeScript docs show the package-style template form for extends (astro/tsconfigs/base, and the same template family includes strict/strictest): https://docs.astro.build/en/guides/typescript/#tsconfig-templates

Changing it to ./node_modules/astro/tsconfigs/strict.json hardcodes the dependency install layout into project config. That can fix one local editor setup while making the repo less portable across package managers/install modes. Also, this repo does not currently have typescript installed, so pnpm exec tsc --showConfig fails with Command "tsc" not found; the PR has not really proven a TypeScript config check.

Could you include the exact editor error and environment where astro/tsconfigs/strict fails? If the issue is editor tooling, the safer fix may be documenting/reinstalling dependencies or adding the needed checker tooling, rather than pointing tsconfig directly into node_modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants