Skip to content

Fix: Resolve nested anchor tag bug in project cards #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nirobnk wants to merge 1 commit into
base: main
Choose a base branch
from
+33 −20
Open

Fix: Resolve nested anchor tag bug in project cards #599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 33 additions & 20 deletions src/components/ProjectCard.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,20 @@ const { projectLink, logoLink, name, description, tags = [], loadIssues = false
---

<div class="Card-Container">
<a class="Card-Real-Link" href={projectLink} target="_blank">
<div class="Card-Header">
<img
class="Project-Logo"
alt="the framework or language that the project is build upon"
src={logoLink}
onerror="this.src='/default.png'"
width="60"
height="60"
/>
<p class="Card-Title">{name}</p>
</div>
<div class="Card-Content">
<a class="Card-Header-Link" href={projectLink} target="_blank">
<div class="Card-Header">
<img
class="Project-Logo"
alt="the framework or language that the project is build upon"
src={logoLink}
onerror="this.src='/default.png'"
width="60"
height="60"
/>
<p class="Card-Title">{name}</p>
</div>
</a>
<div class="Card-Body">
<div class="Card-Tag">
{tags.map((tag) => (
Expand All @@ -41,10 +43,10 @@ const { projectLink, logoLink, name, description, tags = [], loadIssues = false
<IssueList projectLink={projectLink} projectName={name} />
)}
</div>
<div class="Card-Link">
<a class="Card-Link" href={projectLink} target="_blank">
<span>Go to Project</span>
</div>
</a>
</a>
</div>
</div>

<style>
Expand Down Expand Up @@ -86,17 +88,25 @@ const { projectLink, logoLink, name, description, tags = [], loadIssues = false
background: rgba(255, 255, 255, 0.12);
}

.Card-Real-Link {
display: block;
text-decoration: none;
color: inherit;
height: 100%;
.Card-Content {
display: flex;
flex-direction: column;
height: 100%;
position: relative;
z-index: 1;
}

.Card-Header-Link {
text-decoration: none;
color: inherit;
display: block;
transition: opacity 0.2s ease;
}

.Card-Header-Link:hover {
opacity: 0.9;
}

.Card-Header {
padding: 1.5rem 1.5rem 1rem;
text-align: center;
Expand Down Expand Up @@ -170,6 +180,9 @@ const { projectLink, logoLink, name, description, tags = [], loadIssues = false
transition: all 0.3s ease;
position: relative;
overflow: hidden;
text-decoration: none;
display: block;
cursor: pointer;
}

.Card-Link::before {
Expand Down