[codex] fix guide page metadata#601
Closed
Sean-Kenneth-Doherty wants to merge 5 commits into
Closed
Conversation
Author
|
Withdrawing this to keep the contribution queue focused on the highest-signal fixes. I opened too many small slices here, and this one is less important than the concrete broken-link, security, workflow, rendering, and accessibility fixes that remain open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
name="twitter:*"meta attributes on the guide page.lang="en"to the standalone guide page shell.<title>markup so the rendered title text stays at 64 characters without extra whitespace.Addresses #348.
Related to #347.
Validation
magick public/og-image.svg public/og-image.pngfile public/og-image.pngandidentify public/og-image.pngconfirmed a 1200x630 PNGpnpm build<!DOCTYPE html><html lang="en">, the canonical link is present, no meta canonical remains, no firstcontributions.github.io/assets metadata references remain, guide image metadata points tohttps://firstcontributions.github.io/og-image.png, referenced og-image.png/favicon.svg files exist in dist, guide Twitter Card tags render asname="twitter:*", and guide<title>/ metadata titles are 64 characters.git diff --checkReference: https://developer.x.com/cards/markup