Skip to content

[codex] fix issue label class binding#610

Open
Sean-Kenneth-Doherty wants to merge 1 commit into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/fix-issue-label-classes
Open

[codex] fix issue label class binding#610
Sean-Kenneth-Doherty wants to merge 1 commit into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/fix-issue-label-classes

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

Summary

  • Fix the dynamic issue label class binding in IssueList.astro.
  • Let rendered issue cards receive either good-first-issue or help-wanted so the existing modifier styles apply.

Why

The previous class attribute included the conditional expression inside a plain string, so Astro rendered the expression text literally in the built HTML instead of evaluating it.

Validation

  • pnpm build
  • Confirmed dist/index.html renders Issue-Label good-first-issue and no longer contains {issue.priority ...}
  • git diff --check

@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Fresh validation against the current PR head (0936f70):

  • the PR is scoped to src/components/IssueList.astro and fixes the issue-label class binding
  • source now uses a template literal class expression instead of rendering the literal {issue.priority ...} string
  • GITHUB_TOKEN=$(gh auth token) pnpm build -> Astro build succeeded, 2 pages
  • generated dist/index.html contains 9 issue labels, 0 unresolved template-expression class strings, and rendered classes like Issue-Label good-first-issue
  • git diff --check origin/main...HEAD -> clean

I validated this in an isolated temporary git worktree so generated .astro/dist output did not touch the main checkout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant