Skip to content

[codex] remove rendered key attributes from tags#613

Closed
Sean-Kenneth-Doherty wants to merge 1 commit into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/remove-project-tag-key-attrs
Closed

[codex] remove rendered key attributes from tags#613
Sean-Kenneth-Doherty wants to merge 1 commit into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/remove-project-tag-key-attrs

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

Summary

  • Remove the React-only key attribute from project tag wrappers in ProjectCard.astro.

Why

Astro does not treat key={tag} as a framework diffing hint in this server-rendered markup, so it was emitted into the final HTML as key="..." on every project tag wrapper. Removing it keeps the generated markup cleaner and avoids invalid/noisy attributes.

Validation

  • pnpm build
  • Confirmed built dist/index.html no longer contains <div key="..."> project tag wrappers
  • git diff --check

Contributes to #347.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty marked this pull request as ready for review May 16, 2026 23:53
@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Withdrawing this to keep the contribution queue focused on the highest-signal fixes. I opened too many small slices here, and this one is less important than the concrete broken-link, security, workflow, rendering, and accessibility fixes that remain open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant