Skip to content

[codex] hide decorative social share icons#614

Open
Sean-Kenneth-Doherty wants to merge 1 commit into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/hide-social-share-icons
Open

[codex] hide decorative social share icons#614
Sean-Kenneth-Doherty wants to merge 1 commit into
firstcontributions:mainfrom
Sean-Kenneth-Doherty:codex/hide-social-share-icons

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

Summary

  • Mark the inline social-share SVG icons as decorative with aria-hidden="true" and focusable="false".

Why

Each social share card already has visible text that names the destination, so the SVGs should not add extra noise to assistive technology output.

Validation

  • pnpm build
  • Confirmed built dist/index.html renders all three social SVGs with aria-hidden="true" and focusable="false"
  • git diff --check

Contributes to #347.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty marked this pull request as ready for review May 16, 2026 23:53
@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Fresh validation against the current PR head (096019d):

  • the PR is scoped to src/components/SocialShare.astro
  • the three social-share SVG icons are marked aria-hidden="true" and focusable="false"
  • the share links and visible text labels remain in place for Twitter, Facebook, and LinkedIn
  • GITHUB_TOKEN=$(gh auth token) pnpm build -> Astro build succeeded, 2 pages
  • generated dist/index.html contains the social-share section, 3 share links, 3 visible labels, and 3 decorative SVGs hidden from assistive tech
  • git diff --check origin/main...HEAD -> clean

I validated this in an isolated temporary git worktree so generated .astro/dist output did not touch the main checkout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant