refactor(flame_3d): Simplify uniform slot definitions and allocations#3873
Open
wolfenrain wants to merge 3 commits intomainfrom
Open
refactor(flame_3d): Simplify uniform slot definitions and allocations#3873wolfenrain wants to merge 3 commits intomainfrom
wolfenrain wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
flutter_gpuand Impeller we can look up the actual uniforms on the shader, get their size as Impeller expects it and validate if names actually exist. Refactored to use that so our uniform shader approach is a lot more stable and secure.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues