Skip to content

refactor: use duty config change dedupe#2219

Draft
adityathebe wants to merge 1 commit into
mainfrom
feat/duty-change-dedupe
Draft

refactor: use duty config change dedupe#2219
adityathebe wants to merge 1 commit into
mainfrom
feat/duty-change-dedupe

Conversation

@adityathebe
Copy link
Copy Markdown
Member

Config change dedupe has moved to duty so the fingerprint cache and dedupe behavior can be shared.

Delegate cache initialization and dedupe decisions to duty, while keeping a temporary compatibility shim for config-db's local ConfigChange model.

Depends on flanksource/duty#1971.

Config change dedupe now lives in duty with the shared fingerprint cache and dedupe behavior.

Delegate cache initialization and dedupe decisions to duty, keeping a temporary compatibility shim while config-db still uses its local ConfigChange model in the scrape pipeline.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2d769290-292d-4c65-a9ea-3b603bdc48a2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/duty-change-dedupe
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/duty-change-dedupe

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

Benchstat

Base: fcb78acd9715c197245d0465790575bac055ff7d
Head: ecac686af15357fec889b77a9e1d6b503499e1f8

📊 2 minor regression(s) (all within 5% threshold)

Benchmark Base Head Change p-value
BenchSaveResultsUpdateChanged/N=1000-4 75.30Mi 75.67Mi +0.49% 0.004
BenchSaveResultsUpdateChanged/N=1000-4 914.0k 915.0k +0.11% 0.041
✅ 1 improvement(s)
Benchmark Base Head Change p-value
BenchSaveResultsUpdateUnchanged/N=1000-4 130.0k 130.0k -0.01% 0.006
Full benchstat output
goos: linux
goarch: amd64
pkg: github.com/flanksource/config-db/bench
cpu: AMD EPYC 9V74 80-Core Processor                
                                         │ bench-base.txt │           bench-head.txt           │
                                         │     sec/op     │    sec/op     vs base              │
BenchSaveResultsSeed/N=1000-4                959.6m ± 44%   956.0m ± 45%       ~ (p=0.937 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4     101.8m ± 10%   101.6m ±  8%       ~ (p=0.818 n=6)
BenchSaveResultsUpdateChanged/N=1000-4        1.039 ±  1%    1.036 ±  4%       ~ (p=1.000 n=6)
geomean                                      466.4m         465.2m        -0.27%

                                       │ bench-base.txt │           bench-head.txt           │
                                       │      MB/s      │    MB/s     vs base                │
BenchSaveResultsSeed/N=1000-4              0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
BenchSaveResultsUpdateChanged/N=1000-4     0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                         │ bench-base.txt │           bench-head.txt           │
                                         │      B/op      │     B/op      vs base              │
BenchSaveResultsSeed/N=1000-4                36.34Mi ± 0%   36.33Mi ± 0%       ~ (p=0.818 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4     11.52Mi ± 2%   11.52Mi ± 3%       ~ (p=0.589 n=6)
BenchSaveResultsUpdateChanged/N=1000-4       75.30Mi ± 0%   75.67Mi ± 0%  +0.49% (p=0.004 n=6)
geomean                                      31.59Mi        31.63Mi       +0.13%

                                         │ bench-base.txt │          bench-head.txt           │
                                         │   allocs/op    │  allocs/op   vs base              │
BenchSaveResultsSeed/N=1000-4                 442.4k ± 0%   442.4k ± 0%       ~ (p=0.584 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4      130.0k ± 2%   130.0k ± 4%  -0.01% (p=0.006 n=6)
BenchSaveResultsUpdateChanged/N=1000-4        914.0k ± 1%   915.0k ± 1%  +0.11% (p=0.041 n=6)
geomean                                       374.6k        374.8k       +0.03%

                                         │ bench-base.txt │         bench-head.txt          │
                                         │      B/s       │     B/s       vs base           │
BenchSaveResultsUpdateUnchanged/N=1000-4     9.766Ki ± 0%   9.766Ki ± 0%  ~ (p=1.000 n=6) ¹
¹ all samples are equal

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang/​github.com/​flanksource/​duty@​v1.0.1307 ⏵ v1.0.1308-0.20260515121513-ab373e44de4875 +1100100100100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant