Skip to content

fix: preserve explicit notification preference false - #56

Closed
pijiang3 wants to merge 3 commits into
mainfrom
feat/notify-follow-preference
Closed

fix: preserve explicit notification preference false#56
pijiang3 wants to merge 3 commits into
mainfrom
feat/notify-follow-preference

Conversation

@pijiang3

Copy link
Copy Markdown
Contributor

Release change

Preserve explicit follow_preference: false in incident notification override requests so personal_channels is honored.

Compatibility

This changes generated FollowPreference fields from bool to *bool. Existing keyed literals must use flashduty.Bool(false) or flashduty.Bool(true). Publish this change as v0.13.0.

Validation

  • GitHub Actions: Go 1.24 and stable build/test passed.
  • Lint passed with 0 issues.
  • Generate Drift passed.
  • Explicit-false and omitted-field wire tests pass.
  • Independent branch review found no blocking findings.

@ysyneu

ysyneu commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #57, which carries the identical code and OpenAPI change on a clean history. The design-note file under docs/ was local-only scratch and should not have been committed; .gitignore now covers that path. Thanks @pijiang3 — your commit is preserved verbatim in #57.

@ysyneu ysyneu closed this Aug 12, 2026
@ysyneu
ysyneu deleted the feat/notify-follow-preference branch August 12, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants