feat: add description and shortcuts to header menu registration#38
Merged
feat: add description and shortcuts to header menu registration#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
descriptionandshortcutsarray to theregisterHeaderMenuItemcall inaddon/extension.js, following the pattern established in the Ledger engine.Each shortcut entry provides:
title— human-readable section namedescription— one-line summary of what the section doesicon— FontAwesome icon nameroute— the Ember route to transition to on clickShortcuts added: API Keys, Webhooks, Sockets, Events, Logs
Changes
addon/extension.js— expanded the options object passed toregisterHeaderMenuItemwithdescriptionandshortcutsTesting
No logic changes. The shortcuts are purely declarative data consumed by the header menu component in
@fleetbase/ember-ui.