Skip to content

Settings > Integrations > Calendar events: Copy button missing border - #51578

Open
noahtalerman wants to merge 4 commits into
mainfrom
copy-button-fix
Open

Settings > Integrations > Calendar events: Copy button missing border#51578
noahtalerman wants to merge 4 commits into
mainfrom
copy-button-fix

Conversation

@noahtalerman

@noahtalerman noahtalerman commented Aug 19, 2026

Copy link
Copy Markdown
Member

For the following bug:

Summary by CodeRabbit

  • Style
    • Improved alignment of copy controls within input fields.
    • Refined spacing and padding for OAuth scope fields.
    • Updated copy button styling for a clearer, more consistent appearance.
    • Removed unnecessary borders and positioning adjustments from OAuth scope copy controls.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2301e641-8a61-4ce9-948e-6dfd95a80421

📥 Commits

Reviewing files that changed from the base of the PR and between 2ef3bbb and 1323c9f.

📒 Files selected for processing (2)
  • frontend/components/forms/fields/InputField/InputField.tsx
  • frontend/pages/admin/IntegrationsPage/cards/Calendars/_styles.scss
💤 Files with no reviewable changes (1)
  • frontend/pages/admin/IntegrationsPage/cards/Calendars/_styles.scss

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


Walkthrough

The changes update copy-control styling. The shared input copy wrapper no longer uses a top offset or margin. The textarea copy button now uses the secondary variant. Copy-enabled Calendar OAuth scope input containers receive 4px of top padding.

Merge Risk: ⚪ Minimal · up to 1323c

This is a localized frontend fix for the calendar integration copy button and does not present an actionable merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description identifies the bug and manual QA, but it omits most required checklist sections and testing details from the template. Complete the applicable checklist items, state which sections do not apply, and add automated test or testing coverage details.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the affected Calendar events copy button and the missing border fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch copy-button-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.95%. Comparing base (f34a8dd) to head (1323c9f).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #51578    +/-   ##
========================================
  Coverage   68.95%   68.95%            
========================================
  Files        4010     4010            
  Lines      260134   260134            
  Branches    13727    13886   +159     
========================================
+ Hits       179365   179369     +4     
+ Misses      64901    64896     -5     
- Partials    15868    15869     +1     
Flag Coverage Δ
frontend 63.65% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RachelElysia RachelElysia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMIIW - but for consistency we should be fixing this on InputField.tsx

Specifically:
<CopyButton copyText={copyText} variant="subdued" size="small" />

Should be:
<CopyButton copyText={copyText} variant="secondary" size="small" />

@noahtalerman

Copy link
Copy Markdown
Member Author

Thanks @RachelElysia! I think I addressed your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants