Settings > Integrations > Calendar events: Copy button missing border - #51578
Settings > Integrations > Calendar events: Copy button missing border#51578noahtalerman wants to merge 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. WalkthroughThe changes update copy-control styling. The shared input copy wrapper no longer uses a top offset or margin. The textarea copy button now uses the Merge Risk: ⚪ Minimal · up to This is a localized frontend fix for the calendar integration copy button and does not present an actionable merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #51578 +/- ##
========================================
Coverage 68.95% 68.95%
========================================
Files 4010 4010
Lines 260134 260134
Branches 13727 13886 +159
========================================
+ Hits 179365 179369 +4
+ Misses 64901 64896 -5
- Partials 15868 15869 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RachelElysia
left a comment
There was a problem hiding this comment.
CMIIW - but for consistency we should be fixing this on InputField.tsx
Specifically:
<CopyButton copyText={copyText} variant="subdued" size="small" />
Should be:
<CopyButton copyText={copyText} variant="secondary" size="small" />
|
Thanks @RachelElysia! I think I addressed your feedback. |
For the following bug:
Settings > Integrations > Calendar events: Copy button missing border #51576
QA'd all new/changed functionality manually
Summary by CodeRabbit