-
Notifications
You must be signed in to change notification settings - Fork 417
Refactor Dispatcher to improve type hints and simplify callable handling #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fadrian06
wants to merge
35
commits into
master
Choose a base branch
from
dispatcher-rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
6c5d9de
remove Engine @template
fadrian06 12607d9
rename Psr\Container\ContainerInterface -> Container
fadrian06 ae735c1
remove Dispatcher properties redundants explanations
fadrian06 8a4818c
improve typehint of keys before and after inside all events in the Di…
fadrian06 0b0737f
remove $this of return type, it's incompatible with self return type
fadrian06 988c64e
rename $containerInterfaceNS -> $containerFQCN and extract InvalidArg…
fadrian06 5c89341
clarify Dispatcher@run parameters and allows to throw errors inside e…
fadrian06 188f147
invert Dispatcher@setContainerHandler conditional and remove $contain…
fadrian06 7beabae
improve Dispatcher description to reflect its responsibility for disp…
fadrian06 1ae2baf
deprecate Dispatcher events property
fadrian06 318852b
deprecate Dispatcher filters property
fadrian06 7379be0
simplify Dispatcher events values typehint
fadrian06 bf3f86d
reuse Dispatcher@get in Dispatcher@has
fadrian06 bb6932e
throw OutOfBoundsException instead of Exception when event name hasn'…
fadrian06 2682e32
add FilteredCallable to replace Dispatcher events to named callables …
fadrian06 5ea5d5b
add Dispatcher namedFilteredCallables property
fadrian06 2673435
update before and filters signature
fadrian06 2d772f3
update Dispatcher description
fadrian06 80705ec
update Dispatcher@run, set, get, has, hook, clear and reset to use th…
fadrian06 b0203d8
deprecate Dispatcher@runPreFilters, runEvent, runPostFilters and filter.
fadrian06 ddb5762
add default template values in FilteredCallable
fadrian06 7405244
extract Dispatcher::CALLABLE_STRING_OPERATORS
fadrian06 35a6bba
update Dispatcher@fixOutputBuffering description
fadrian06 4afb553
simplify Dispatcher@mustUseContainer
fadrian06 cbc1cb3
refactor Dispatcher@execute
fadrian06 27598bc
ignore spacing after control structures open braces
fadrian06 9e08573
rename Dispatcher namedFilteredCallables -> namedCallables
fadrian06 6afe25d
simplify object creation without container
fadrian06 05831b3
use always global namespace prefix
fadrian06 bdd5bdc
fix Dispatcher@get return type
fadrian06 e48b976
fix phpstan message about Dispatcher@get return type
fadrian06 cfa87be
remove unneccesary references
fadrian06 8e168e6
remove unused $container
fadrian06 17ed787
add more @template
fadrian06 7482506
remove EngineTemplate
fadrian06 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.