core: harden checks#84
Open
edsiper wants to merge 9 commits into
Open
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
…d malformed payloads Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
NULL guards covering every reachable dereference inside the decoder: - skip KeyValue entries whose key or value field is NULL (the cfl_kvlist inserters for non-string types call strlen(key) unguarded, so a NULL key from a hand-crafted payload would crash inside cfl). - reject NULL string_value, NULL array_value/kvlist_value and bytes payloads with len>0 and data==NULL inside AnyValue dispatch. - reject n>0 with a NULL container pointer at every array boundary: resource_spans, scope_spans, spans, attributes, events and links. - skip individual NULL entries inside arrays/events/links so a single malformed entry does not drop the whole batch. - treat a span with a NULL name as INVALID_PAYLOAD instead of relying on ctr_span_create returning NULL (which maps to ALLOCATION_ERROR). Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
…oads Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.