packaging: deprecate unzip and wget in Dockerfiles#11985
Conversation
📝 WalkthroughWalkthroughPackage installation lists in Dockerfiles across all supported distros and architectures are updated. RPM-based distros (CentOS, AlmaLinux, AmazonLinux, RockyLinux) remove ChangesDocker packaging dependency cleanup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0697471289
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Yan Li <sherly_lee@163.com>
0697471 to
2a45007
Compare
|
Please update your commits to follow the contribution guide: https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#commit-changes Specifically needs to follow the "prefix: details" pattern where "packaging" can probably be the prefix. |
|
Please ensure you build it all locally as well with the test script and update the description:
|
Remove unzip and wget from Dockerfile as the latest Fluent Bit codebase no longer depends on these packages. They are legacy artifacts and are no longer required.
For Ubuntu dockerfile, removed unzip but kept wget as it's still invoked
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit
unzipand to de-duplicatewgetentries where they appeared multiple times, keeping the rest of the tooling dependency sets consistent.