Skip to content

packaging: deprecate unzip and wget in Dockerfiles#11985

Open
hahakiki2025 wants to merge 1 commit into
fluent:masterfrom
hahakiki2025:topic/yan/remove-unzip
Open

packaging: deprecate unzip and wget in Dockerfiles#11985
hahakiki2025 wants to merge 1 commit into
fluent:masterfrom
hahakiki2025:topic/yan/remove-unzip

Conversation

@hahakiki2025

@hahakiki2025 hahakiki2025 commented Jun 23, 2026

Copy link
Copy Markdown

Remove unzip and wget from Dockerfile as the latest Fluent Bit codebase no longer depends on these packages. They are legacy artifacts and are no longer required.

For Ubuntu dockerfile, removed unzip but kept wget as it's still invoked


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Chores
    • Updated build container package dependencies across CentOS, AlmaLinux, AmazonLinux, Debian, Ubuntu, Raspbian, and RockyLinux for both amd64 and ARM64 variants.
    • Package install lists were adjusted to remove unzip and to de-duplicate wget entries where they appeared multiple times, keeping the rest of the tooling dependency sets consistent.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Package installation lists in Dockerfiles across all supported distros and architectures are updated. RPM-based distros (CentOS, AlmaLinux, AmazonLinux, RockyLinux) remove unzip and deduplicate wget. Debian removes both wget and unzip. Ubuntu removes only unzip. Raspbian replaces wget and unzip with make, bash, sudo, and dh-make.

Changes

Docker packaging dependency cleanup

Layer / File(s) Summary
RPM-based distros: remove unzip and duplicate wget
dockerfiles/Dockerfile.centos7, packaging/distros/centos/Dockerfile, packaging/distros/almalinux/Dockerfile, packaging/distros/amazonlinux/Dockerfile, packaging/distros/rockylinux/Dockerfile
All yum/dnf install lists across CentOS 7/8/Stream, AlmaLinux 8/9/10, AmazonLinux 2/2023, and RockyLinux 8/9/10 (amd64 and arm64v8 variants) drop unzip and the redundant wget, leaving systemd-devel wget flex bison.
Debian: remove wget and unzip
packaging/distros/debian/Dockerfile
All apt-get install lists across Debian versions (buster, bullseye, bookworm, trixie) for both amd64 and arm64 remove both wget and unzip.
Ubuntu: remove unzip only
packaging/distros/ubuntu/Dockerfile
All apt-get install lists across Ubuntu versions (16.04–26.04) for both amd64 and arm64v8 remove unzip while keeping wget.
Raspbian: replace wget/unzip with make bash sudo dh-make
packaging/distros/raspbian/Dockerfile
All apt-get install lists across Raspbian versions (buster, bullseye, bookworm) replace wget and unzip with make, bash, sudo, and dh-make alongside cmake.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • fluent/fluent-bit#10841: Also modifies dockerfiles/Dockerfile.centos7's yum install package list, specifically addressing duplicate wget entries in the CentOS 7 build image.

Suggested labels

ok-package-test

Suggested reviewers

  • niedbalski
  • celalettin1286
  • patrick-stephens

🐇 Hop hop, the Dockerfiles are lean,
No wget twice, no unzip unseen!
make, bash, sudo fill the Raspbian scene,
Across every distro, all arches pristine.
The build lists are tidy — what a dream! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'packaging: deprecate unzip and wget in Dockerfiles' directly and accurately reflects the main change across all modified Dockerfiles, which consistently remove unzip and wget dependencies.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0697471289

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packaging/distros/ubuntu/Dockerfile Outdated
Signed-off-by: Yan Li <sherly_lee@163.com>
@hahakiki2025 hahakiki2025 force-pushed the topic/yan/remove-unzip branch from 0697471 to 2a45007 Compare June 23, 2026 09:56
@patrick-stephens patrick-stephens added packaging ok-package-test Run PR packaging tests and removed docs-required labels Jun 23, 2026
@patrick-stephens patrick-stephens changed the title Deprecate unzip and wget in Dockerfile packaging: deprecate unzip and wget in Dockerfiles Jun 23, 2026
@patrick-stephens

Copy link
Copy Markdown
Contributor

Please update your commits to follow the contribution guide: https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#commit-changes

Specifically needs to follow the "prefix: details" pattern where "packaging" can probably be the prefix.

@patrick-stephens

Copy link
Copy Markdown
Contributor

Please ensure you build it all locally as well with the test script and update the description:

Run local packaging test showing all targets (including any new ones) build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-package-test Run PR packaging tests packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants