Remove FlutterView (NUI/Dali embedding) support#184
Open
JSUYA wants to merge 3 commits into
Open
Conversation
FlutterView rendered Flutter into a NUI/Dali ImageView via FlutterDesktopViewCreateFromImageView. It depends on dali2-adaptor / dali2-core and keeps breaking against new Tizen platform versions, adding instability for little real usage. Drop the feature. - Delete flutter_tizen_nui.cc, tizen_view_nui.*, tizen_renderer_nui_gl.* - Remove the NUI_SUPPORT build path, dali libs and dali include dirs from BUILD.gn (keep CLIPBOARD_SUPPORT / tizen_clipboard.cc, which shared the api_version != "6.0" block) - Remove FlutterDesktopViewCreateFromImageView and the now-unused FlutterDesktopViewProperties from the public header - Drop NUI branches in flutter_tizen.cc, flutter_tizen_engine.cc, flutter_tizen_view.cc and tizen_renderer_egl.cc, and the HandleNuiKeyEvent path in tizen_input_method_context.*
The embedder no longer links dali (FlutterView/NUI removed), so the sysroot no longer needs the dali2 runtime/devel packages. Drop the dali_packages / dali_integration_devel_packages lists and the api_version-gated appends; the package set is now just base_packages + unified_packages.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes NUI (Natural User Interface) support and Dali library dependencies from the Tizen embedder, including deleting NUI-specific views, renderers, and associated build configurations. Feedback recommends addressing unused parameters in FlutterDesktopViewOnKeyEvent resulting from this cleanup to avoid compiler warnings.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlutterView rendered Flutter into a NUI/Dali ImageView via FlutterDesktopViewCreateFromImageView. It depends on dali2-adaptor / dali2-core and keeps breaking against new Tizen platform versions, adding instability for little real usage. Drop the feature.
flutter-tizen/flutter-tizen#788
flutter-tizen/flutter-tizen#789