Skip to content

[tizen_window_manager] Add tizen-core-wl window backend#1057

Open
JSUYA wants to merge 1 commit into
flutter-tizen:masterfrom
JSUYA:tizen-core-wl-window-backend
Open

[tizen_window_manager] Add tizen-core-wl window backend#1057
JSUYA wants to merge 1 commit into
flutter-tizen:masterfrom
JSUYA:tizen-core-wl-window-backend

Conversation

@JSUYA

@JSUYA JSUYA commented Jul 8, 2026

Copy link
Copy Markdown
Member

Introduce a WindowProxyInterface abstraction with two backends selected at runtime by WindowProxy:

  • TizenCoreWlWindowProxy (tizen-core-wl) on Tizen API version >= 11.0 when the library is available
  • EcoreWl2WindowProxy (ecore_wl2) otherwise, including as a fallback when tizen-core-wl cannot be loaded on 11.0+

Both backends implement WindowProxyInterface (GetGeometry/Activate/Lower) and resolve their symbols at runtime via dlopen/dlsym. TizenWindowManager constructs WindowProxy, which picks the backend by querying the platform version at startup.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a WindowProxyInterface and a WindowProxy wrapper to abstract window operations, allowing the Tizen window manager to dynamically switch between EcoreWl2WindowProxy and a new TizenCoreWlWindowProxy backend depending on the platform version. Feedback on the changes suggests resolving and caching the dynamic library symbols in the constructor of TizenCoreWlWindowProxy rather than on every method call. This optimization would also ensure that if any required symbols are missing, the proxy can gracefully fall back to the EcoreWl2WindowProxy backend.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/tizen_window_manager/tizen/src/tizen_core_wl_window_proxy.cc Outdated
@JSUYA JSUYA force-pushed the tizen-core-wl-window-backend branch from 4c66c75 to e3d4a47 Compare July 8, 2026 09:05
Introduce a WindowProxyInterface abstraction with two backends selected at
runtime by WindowProxy:
  - TizenCoreWlWindowProxy (tizen-core-wl) on Tizen API version >= 11.0 when
    the library is available
  - EcoreWl2WindowProxy (ecore_wl2) otherwise, including as a fallback when
    tizen-core-wl cannot be loaded on 11.0+

Both backends implement WindowProxyInterface (GetGeometry/Activate/Lower) and
resolve their symbols at runtime via dlopen/dlsym. TizenWindowManager
constructs WindowProxy, which picks the backend by querying the platform
version at startup.
@JSUYA JSUYA force-pushed the tizen-core-wl-window-backend branch from e3d4a47 to 7bf463a Compare July 8, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant