fix: prevent redundant presubmit builds by checking for existing LUCI…#5083
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a check in the scheduler to prevent re-running presubmit checks if builds already exist for the current SHA, avoiding redundant cancellations and recreation of builds. The feedback points out a critical issue with this logic: checking if any build exists (including completed, failed, or canceled ones) will prevent developers from retrying failed builds. The reviewer suggests modifying the check to only return early if there are active builds (i.e., with a status of 'SCHEDULED' or 'STARTED') and provides corresponding updates for the test mocks.
jtmcdole
reviewed
Jun 23, 2026
… builds for the current SHA before scheduling
…ting try builds are detected
ievdokdm
added
CICD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid re-running all checks if the CICD label is removed and added after presubmits have started, check if builds already exist for the current SHA. If builds already exist, there is no need to cancel them and create new ones.
fix: flutter/flutter#188126