Add pre-commit hook to verify static analysis passes & format is correct#11941
Draft
camsim99 wants to merge 7 commits into
Draft
Add pre-commit hook to verify static analysis passes & format is correct#11941camsim99 wants to merge 7 commits into
camsim99 wants to merge 7 commits into
Conversation
camsim99
commented
Jun 18, 2026
Contributor
Author
There was a problem hiding this comment.
My main worry as of now is that this is sorta slow. For a one char add in a package, it took like 20s. We could potentially cut this down by only formatting Dart files. But I also don't know if it's a huge concern if the main use case here is for agents making sure they are making acceptable commits.
camsim99
commented
Jun 18, 2026
Contributor
Author
There was a problem hiding this comment.
I also want to add here some tests that integration-ish test that format and analyze are at least in simple cases, doing what we expect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pre-commit hook that you can install to verify that
dart analyzeand the package format are correct when you make a call togit commit. Intended to be used when agents are autonomously making & committing changes.Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2