Skip to content

Add pre-commit hook to verify static analysis passes & format is correct#11941

Draft
camsim99 wants to merge 7 commits into
flutter:mainfrom
camsim99:cos_precommit
Draft

Add pre-commit hook to verify static analysis passes & format is correct#11941
camsim99 wants to merge 7 commits into
flutter:mainfrom
camsim99:cos_precommit

Conversation

@camsim99

Copy link
Copy Markdown
Contributor

Adds a pre-commit hook that you can install to verify that dart analyze and the package format are correct when you make a call to git commit. Intended to be used when agents are autonomously making & committing changes.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main worry as of now is that this is sorta slow. For a one char add in a package, it took like 20s. We could potentially cut this down by only formatting Dart files. But I also don't know if it's a huge concern if the main use case here is for agents making sure they are making acceptable commits.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also want to add here some tests that integration-ish test that format and analyze are at least in simple cases, doing what we expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant