Update chrome version in ci.yaml to (probably) unblock tree - #12498
Closed
gmackall wants to merge 2 commits into
Closed
Update chrome version in ci.yaml to (probably) unblock tree#12498gmackall wants to merge 2 commits into
ci.yaml to (probably) unblock tree#12498gmackall wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the chrome_and_driver dependency version in .ci.yaml. The review feedback recommends updating all other occurrences of the chrome_and_driver dependency in the file to match this new version to prevent potential version mismatch issues and test failures across different platforms.
Member
Author
|
Hmm I didn't check if someone else had already done this and it looks like Tarrin already got this far ignore this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the
chrome_and_driverCIPD dependency in.ci.yamlfrom125.0.6422.141to145.0.7632.117to align withflutter/flutter.Gemini suspects this is what's causing the timeouts in the tree:
and that seems reasonable to me