feat: Support image conversion for PDF URLs#111
Open
BenJuan26 wants to merge 2 commits intoflybywiresim:mainfrom
Open
feat: Support image conversion for PDF URLs#111BenJuan26 wants to merge 2 commits intoflybywiresim:mainfrom
BenJuan26 wants to merge 2 commits intoflybywiresim:mainfrom
Conversation
BenJuan26
changed the title
Lucky38i
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #110
contributes to flybywiresim/aircraft#5768
Remaining work:
Description
ChartFox provides some charts in PDF format. Since they can't be converted in the EFB itself, this service will allow support for those charts as long as there is a SimBridge connection.
I've mostly duplicated the existing functions for local files, but added
FromUrlon the end. For the paths, I kept everything mostly the same, just under the/fromUrlsubpath. It could probably be cleaned up in its current form, but it works in its current form.Proof this works
Get PDF image:
Get page count:
Get page count for multi-page PDF:
Get page > 1: