Fix flytekit-greatexpectations tests: replace dead ge_tutorials CSV URL - #3461
Merged
Conversation
The superconductive/ge_tutorials repo no longer exists, so the raw CSV URL 404s and 6 remote-FlyteFile tests fail on master. Point them at the byte-identical copies already committed under plugins/flytekit-greatexpectations/tests/data/ on master. Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
cosmicBboy,
davidmirror-ops,
kumare3,
machichima,
samhita-alla and
wild-endeavor
as code owners
August 18, 2026 05:55
popojk
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
build-plugins (flytekit-greatexpectations)is failing on master. Thesuperconductive/ge_tutorialsGitHub repo no longer exists, sohttps://raw.githubusercontent.com/superconductive/ge_tutorials/main/data/yellow_tripdata_sample_2019-01.csvreturns 404 and every test that feeds a remote
FlyteFile/CSVFileinto aGreat Expectations task blows up with:
6 failures:
test_schema.py::test_ge_schema_remote_flytefile,test_ge_schema_remote_flytefile_literal,test_task.py::test_ge_remote_flytefile,test_ge_remote_flytefile_with_task,test_ge_remote_flytefile_workflow,test_ge_flytefile_multiple_args.What changes were proposed in this pull request?
Point those URLs at the copies of the same CSVs that are already committed in
this repo under
plugins/flytekit-greatexpectations/tests/data/, served overraw.githubusercontent.com from
master. That keeps the tests exercising theremote-http download path (which is the point of these tests) while removing
the dependency on a third-party repo we don't control.
Both files are byte-identical to the local ones the other tests already use
(md5
38f1366...for 2019-01,e39a6b8...for 2019-02), so the== 10000row assertions are unchanged.
I also checked
great-expectations/gx_tutorialsas a replacement — it is live,but its
2019-01sample has 9999 rows instead of 10000 and its2019-02samplediffers, so it would have required changing the assertions.
How was this patch tested?
No new tests — this restores 6 existing tests that fail on master.
Verified the new URLs resolve and that flytekit's
CSVFiledownload pathreturns the expected row count:
The full plugin suite needs great-expectations + pyspark 3.3.2, which I did not
install locally — CI on this PR is the real check.
Check all the applicable boxes