Skip to content

Prepare use of import std;#4848

Open
ClausKlein wants to merge 8 commits into
fmtlib:mainfrom
ClausKlein:feature/add-import-std
Open

Prepare use of import std;#4848
ClausKlein wants to merge 8 commits into
fmtlib:mainfrom
ClausKlein:feature/add-import-std

Conversation

@ClausKlein

@ClausKlein ClausKlein commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Tested only on OSX with g++-16 and CMake v4.4

use GNUmakefile as usage hint.

This fix too #4695

@ClausKlein ClausKlein requested a review from vitaut as a code owner July 13, 2026 17:30
The fmt project use CXX and CC
@ClausKlein ClausKlein force-pushed the feature/add-import-std branch from eaebdb4 to 09d5278 Compare July 13, 2026 18:06
@ClausKlein ClausKlein marked this pull request as draft July 13, 2026 18:34
@ClausKlein

ClausKlein commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@vitaut is clang++-3.6 really needed on CI?

export CC="${CXX/clang++/clang}"
;;
esac
echo "CC=$CC"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI used the default $CC compiler until now?

@ClausKlein ClausKlein force-pushed the feature/add-import-std branch from fbbcbd6 to e424a93 Compare July 13, 2026 21:42
@ClausKlein ClausKlein marked this pull request as ready for review July 13, 2026 21:49
strategy:
matrix:
cxx: [g++-4.9, g++-11, clang++-3.6, clang++-11]
cxx: [g++-4.9, g++-11, clang++-11]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with clang-11 compiler fails the ci build job!

project(fmt-test)
project(fmt-test CXX)

find_package(FMT REQUIRED)

@ClausKlein ClausKlein Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how dit this work?

the config file is: fmt-config.cmake

see #4849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant