chore(lint): drain the standing violation baseline - #707
Merged
Conversation
- ReleaseMetadata gains a validating constructor (non-empty title/URL at the persistence boundary); ReleasePersistError is now #[non_exhaustive] with the bridge's match given a forward-safe arm. - Two wall-clock tests rewritten to deterministic forms (paused-clock timeout wrapper; outer-timeout bound) — the asserted property is unchanged. The paused-clock retry-after test is suppressed with a WHY (virtual time is exact, not wall latency). - Internal .lan FQDN literals out of CONTRIBUTING.md and docs/integrations.md (placeholder / reserved example domain). - Four stale suppression entries deleted (matched no files), including a per-crate ignore file whose field was deleted in #575. - The hybrid-gate @main call is suppressed with a WHY: fleet-owned reusable workflow, deliberate single-update channel. The flake-lock violation resolves with #706, taking the workspace to zero. Refs #705
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drains the standing basanos violation baseline (12 → 1, and that one —
NIX/flake-lock-committed— resolves when #706 merges, taking the workspace to zero). Per the operator's standing rule that the baseline and suppressions are in scope.Real fixes:
paroche/routes/download.rs:ReleaseMetadatagains a validating constructor — non-empty title/URL enforced once at the persistence boundary; both construction sites (HTTP route, MCP bridge) now go through it.ReleasePersistErroris#[non_exhaustive]with a newEmptyMetadatavariant and a forward-safe wildcard arm in the bridge's match.eksetasis/rate_limit.rs+komide/fetch.rs: the two genuinely wall-clock tests rewritten — paused-clock +tokio::time::timeoutas the bound. Same properties asserted (prompt cancel-unblock; client timeout beats a stalled server), noInstant::now()measurement.CONTRIBUTING.md/docs/integrations.md: internal.lanFQDN literals replaced (placeholder for the forge host; reservedexample.comdomain for the KOReader examples).Suppressions (each with a WHY):
search/tests.rswall-clock: the assertion measurestokio::time::Instantunder an explicitly paused clock — virtual time, deterministic by construction; the rule's flake concern doesn't apply.gate-attestation.ymlunpinned-action:forkwright/.githubis fleet-owned and@mainis the deliberate single-update channel for the shared hybrid gate (9 of 10 fleet repos call it this way).Cruft deleted: four stale suppression entries that matched no files (an as-cast glob for a moved module, a checksum glob, a dep-count entry, and a per-crate ignore file whose suppressed field was removed in #575).
Verification
Refs #705 (the full 159-entry suppression audit is its own campaign)