Skip to content

Revert "Emit major-only clarified_version for android.googlesource URLs"#278

Merged
soimkim merged 1 commit into
mainfrom
revert-272-dep2
May 13, 2026
Merged

Revert "Emit major-only clarified_version for android.googlesource URLs"#278
soimkim merged 1 commit into
mainfrom
revert-272-dep2

Conversation

@soimkim
Copy link
Copy Markdown
Contributor

@soimkim soimkim commented May 13, 2026

Reverts #272

@soimkim soimkim self-assigned this May 13, 2026
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label May 13, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f2cc2f3d-2c4e-4d96-aefa-a4bb7234f8b2

📥 Commits

Reviewing files that changed from the base of the PR and between 6ff949e and a0d39d9.

📒 Files selected for processing (1)
  • src/fosslight_util/download.py
💤 Files with no reviewable changes (1)
  • src/fosslight_util/download.py

📝 Walkthrough

Walkthrough

This PR simplifies version handling in the download utility by removing special-case logic for android.googlesource.com URLs. The cli_download_and_extract() function now uses a uniform version clarification approach across all sources, and the supporting _major_only_version() helper function is removed since it is no longer needed.

Changes

Version Handling Simplification

Layer / File(s) Summary
Remove Android-specific version clamping and helper function
src/fosslight_util/download.py
cli_download_and_extract() now directly uses clarified_version_from_oss_version() without applying major-only reduction for android.googlesource.com URLs. The _major_only_version() helper is deleted.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the change as a revert of a specific previous commit, accurately reflecting the modification that removes Android special-case handling from the download logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-272-dep2

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@soimkim soimkim merged commit 1b0e0b9 into main May 13, 2026
7 of 8 checks passed
@soimkim soimkim deleted the revert-272-dep2 branch May 13, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant