-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 데모 사업장 및 근로자 시드 데이터 확장 #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krestar
wants to merge
3
commits into
main
Choose a base branch
from
feature/demo-company-workers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
...ain/java/com/fowoco/server/demo/infrastructure/seed/DemoOperationalSeedConfiguration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package com.fowoco.server.demo.infrastructure.seed; | ||
|
|
||
| import com.fowoco.server.audit.application.port.AuditEventRepository; | ||
| import com.fowoco.server.auth.infrastructure.seed.DemoAuthSeedProperties; | ||
| import com.fowoco.server.task.application.TaskContentCodec; | ||
| import com.fowoco.server.task.application.port.TaskRepository; | ||
| import com.fowoco.server.worker.application.port.WorkerDocumentRepository; | ||
| import java.time.Clock; | ||
| import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| @Configuration(proxyBeanMethods = false) | ||
| public class DemoOperationalSeedConfiguration { | ||
|
|
||
| @Bean | ||
| @ConditionalOnProperty(prefix = "app.demo-seed", name = "enabled", havingValue = "true") | ||
| DemoOperationalSeedRunner demoOperationalSeedRunner( | ||
| DemoAuthSeedProperties properties, | ||
| TaskRepository taskRepository, | ||
| TaskContentCodec taskContentCodec, | ||
| WorkerDocumentRepository workerDocumentRepository, | ||
| AuditEventRepository auditEventRepository, | ||
| Clock clock | ||
| ) { | ||
| return new DemoOperationalSeedRunner( | ||
| properties, | ||
| taskRepository, | ||
| taskContentCodec, | ||
| workerDocumentRepository, | ||
| auditEventRepository, | ||
| clock | ||
| ); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
재성님 데이터 만들어주신거 감사합니다. 추가로 만들어 주셨으면 하는 데이터가 있어서 리뷰 남깁니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
클라이언트 화면 검증 관점에서 보면 Task/Document/AuditEvent 시드가 없어서, 이 PR만으로는 대시보드·업무함·문서함·근로자 상세 화면이 전부 빈 상태로만 보이게 되어서 화면 확인이 어려워요. 화면 확인을 위해 아래 데이터도 함께 시드해주실 수 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
데이터 모델·API 변경 없이 시드 데이터만 추가하는 선에서 가능하면, 이번 PR 범위에 포함하거나 후속 PR로 분리해주셔도 좋을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hywznn teams에 적었던 내용인데 참고해서 현준님도 리뷰 부탁드립니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BcKmini 위를 구분짓게 해주기 위해서 문서에 있는 slot에서 필요한 데이터들을 최대한 다 넣어달라고 했는데 + 라벨값들도 같이 넣어달라고 하겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 참고해주세요
READY_FOR_REVIEW/DRAFT/COMPLETED), 기한 다양MISSING/SUBMITTED/VERIFIED) + 만료 임박 건due_date·expiry_date다양한 값