Open
Conversation
stijnpotters1
requested review from
Daan0709 and
Matthbo
and removed request for
Copilot
|
Matthbo
reviewed
Mar 25, 2026
Comment on lines
+53
to
+95
| tokenizer: { | ||
| root: [ | ||
| [/[^<&]+/, ''], | ||
| [/&\w+;/, 'string.escape'], | ||
| [/<!\[CDATA\[/, { token: 'delimiter.cdata', next: '@cdata' }], | ||
| [/<!--/, { token: 'comment', next: '@comment' }], | ||
| [/(<\?)(\w[\w\d.]*)/, [{ token: 'delimiter' }, { token: 'metatag', next: '@xmlDecl' }]], | ||
| [/(<\/)(\w[\w\d.:_-]*)/, [{ token: 'delimiter' }, { token: 'tag', next: '@tag' }]], | ||
| [/(<)(\w[\w\d.:_-]*)/, [{ token: 'delimiter' }, { token: 'tag', next: '@tag' }]], | ||
| [/</, { token: 'delimiter' }], | ||
| ], | ||
| cdata: [ | ||
| [/[^\]]+/, ''], | ||
| [/\]\]>/, { token: 'delimiter.cdata', next: '@pop' }], | ||
| [/\]/, ''], | ||
| ], | ||
| xmlDecl: [ | ||
| [/\s+/, ''], | ||
| [/[\w:-]+/, 'attribute.name'], | ||
| [/=/, 'delimiter'], | ||
| [/"[^"]*"/, 'attribute.value'], | ||
| [/'[^']*'/, 'attribute.value'], | ||
| [/\?>/, { token: 'delimiter', next: '@pop' }], | ||
| ], | ||
| tag: [ | ||
| [/\s+/, ''], | ||
| // flow: namespace attributes — literal regexes, matched before generic rules | ||
| [/((?:xmlns:flow|flow:[\w-]+))(\s*=\s*(?:"[^"]*"|'[^']*'))/, ['flow-attribute', 'flow-attribute-value']], | ||
| [/(?:xmlns:flow|flow:[\w-]+)/, 'flow-attribute'], | ||
| // Regular attributes | ||
| [/([\w.:_-]+)(\s*=\s*(?:"[^"]*"|'[^']*'))/, ['attribute.name', 'attribute.value']], | ||
| [/[\w.:_-]+/, 'attribute.name'], | ||
| [/=/, 'delimiter'], | ||
| [/\/>/, { token: 'delimiter', next: '@pop' }], | ||
| [/>/, { token: 'delimiter', next: '@pop' }], | ||
| ], | ||
| comment: [ | ||
| [/-->/, { token: 'comment', next: '@pop' }], | ||
| [/[^-]+/, 'comment'], | ||
| [/--/, 'comment'], | ||
| [/./, 'comment'], | ||
| ], | ||
| }, |
Member
There was a problem hiding this comment.
Why is this needed?
Isn't the default XML highlighter enough?
This seems like a lot of manual logic to do what should either already be done through monaco's highlighting itself or adds something custom that normal editors usually don't have either
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed theme to flow-vs-{theme} instead of vs-{theme} to prevent internal monaco editor theme conflicts