-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor filesystem path resolution and enhance directory browsing logic #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stijnpotters1
wants to merge
6
commits into
master
Choose a base branch
from
feat/fallback-directory-picker-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
898ab14
Refactor filesystem path resolution and enhance directory browsing logic
stijnpotters1 5952c6a
Fix directory navigation logic to ensure 'canGoUp' is correctly deter…
stijnpotters1 2b25b30
Add parentPath to BrowseResult and update related logic for directory…
stijnpotters1 675e338
Add unit tests for FileSystemStorage browse functionality and improve…
stijnpotters1 f247c7f
Update FilesystemControllerTest to use browse method and adjust asser…
stijnpotters1 f2bf84e
Enhance path handling in FileSystemStorage and add unit tests for Lin…
stijnpotters1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| import { apiFetch } from '~/utils/api' | ||
| import type { FilesystemEntry } from '~/types/filesystem.types' | ||
| import type { BrowseResult } from '~/types/filesystem.types' | ||
|
|
||
| export const filesystemService = { | ||
| async browse(path = ''): Promise<FilesystemEntry[]> { | ||
| async browse(path = ''): Promise<BrowseResult> { | ||
| return apiFetch(`/filesystem/browse?path=${encodeURIComponent(path)}`) | ||
| }, | ||
|
|
||
| async getDefaultPath(): Promise<string> { | ||
| const result = await apiFetch<{ path: string }>('/filesystem/default-path') | ||
| return result.path | ||
| async resolveNearestAccessiblePath(path: string): Promise<string> { | ||
| const result = await this.browse(path) | ||
| return result.resolvedPath | ||
| }, | ||
|
stijnpotters1 marked this conversation as resolved.
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
src/main/java/org/frankframework/flow/filesystem/BrowseResult.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package org.frankframework.flow.filesystem; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| public record BrowseResult(String resolvedPath, String parentPath, List<FilesystemEntry> entries) {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.