Fix plus decoding in URL search hashes#2695
Merged
simon04 merged 1 commit intoJun 21, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes URL hash-based searches where literal + characters (e.g., c++) were incorrectly treated as spaces during decoding, which broke scoped searches like #q=c++%20std::min.
Changes:
- Added
$.urlDecodeFragmentto decode hash fragments without converting+into spaces. - Updated
SearchandSearchScopehash parsing to use$.urlDecodeFragment. - Added a focused Node test covering scoped C++ URL searches and encoded literal plus queries.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| assets/javascripts/lib/util.js | Adds $.urlDecodeFragment for fragment decoding that preserves literal +. |
| assets/javascripts/views/search/search.js | Switches hash decoding to $.urlDecodeFragment when extracting the query. |
| assets/javascripts/views/search/search_scope.js | Switches hash decoding to $.urlDecodeFragment for scoped hash extraction and rewrite. |
| test/assets/search_hash_test.js | Adds a Node VM-based test covering the C++ scoped query regression and %2B literal plus decoding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+charactersSearchandSearchScopeFixes #2463.
Tests
node --test test/assets/search_hash_test.jsnode --check assets/javascripts/lib/util.js && node --check assets/javascripts/views/search/search.js && node --check assets/javascripts/views/search/search_scope.js && node --check test/assets/search_hash_test.jsgit diff --checkNot run locally:
bundle exec rakebecause this checkout requires Ruby 4.0.5 and Bundler 4.0.12, while this machine only has system Ruby 2.6.10 and no matching Bundler.