[Repo Assist] feat: add Imputation.kNearestWeightedImpute for distance-weighted KNN#372
Draft
github-actions[bot] wants to merge 2 commits intodeveloperfrom
Conversation
Adds Imputation.kNearestWeightedImpute to FSharp.Stats.ML, addressing the weighted KNN imputation request in #318. The new function accepts a pluggable distance metric and a distanceToWeight converter, allowing both inverse-Euclidean and similarity-based (e.g. Pearson correlation) weighting strategies. Changes: - src/FSharp.Stats/ML/Imputation.fs: new kNearestWeightedImpute function - tests/FSharp.Stats.Tests/Imputation.fs: 6 new tests (1200/1200 pass) - tests/.../FSharp.Stats.Tests.fsproj: register new test file Closes #318 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Implements the distance-weighted KNN imputation variant requested in #318, adding
Imputation.kNearestWeightedImputetoFSharp.Stats.ML.Motivation
The existing
kNearestImputetreats all k neighbours equally (simple mean). Issue #318 asks for:euclideanNaNSquared)Changes
src/FSharp.Stats/ML/Imputation.fsNew function:
Parameters
distanceMetricfloat[] → float[] → floatdistance; useDistanceMetrics.Array.euclideanNaNSquaredto skip NaN positionsdistanceToWeightfun d → 1.0 / (d + epsilon); for a correlation similarity measure passidor its reciprocalkBehaviour
knearest complete rows bydistanceMetric.distanceToWeight(distance).totalWeight = 0(all weights zero), falls back to an unweighted mean (graceful degradation).nanif the complete-rows pool is empty.Typical usage
Notes & Trade-offs
kNearestImputeis unchanged.Impute→ already deprecated), missing-value encoding parameterisation, and documentation examples. These could be tackled in follow-up PRs or directly by the maintainer.euclideanNaNSquaredreturns 0. Callers using1/(d+epsilon)still get numerically stable results becauseepsilonprevents true division-by-zero and the equal-weight case degrades to the arithmetic mean.Closes #318