Shut down background cache workers on file close - #2069
Merged
martindurant merged 2 commits intoJul 28, 2026
Conversation
BackgroundBlockCache executors and their pending prefetches survived when a buffered file discarded its cache. Close the cache first, stop its executor, and break the bound-method reference cycle so the file can be released. Add a regression test that verifies closed files reject new background work. Fixes fsspec#2008
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing an
AbstractBufferedFilecurrently discards itsBackgroundBlockCachewithout stopping the executor. ItsUpdatableLRUalso retains a bound cache method, so repeated background-cached reads can retain workers, files, and cached blocks until cyclic GC runs.This adds idempotent shutdown that cancels pending prefetch work, joins the executor, and breaks the reference cycle before the buffered file drops the cache. The regression test fails on
masterbecause the executor still accepts work afterclose()and passes once the cache is released.Fixes #2008.