Skip to content

Document intentional non-caching and fallback behavior for UNKNOWN bucket layouts#844

Merged
zhixiangli merged 1 commit into
fsspec:mainfrom
Yonghui-Lee:cache-unknown-buckets-pure
May 26, 2026
Merged

Document intentional non-caching and fallback behavior for UNKNOWN bucket layouts#844
zhixiangli merged 1 commit into
fsspec:mainfrom
Yonghui-Lee:cache-unknown-buckets-pure

Conversation

@Yonghui-Lee
Copy link
Copy Markdown
Collaborator

@Yonghui-Lee Yonghui-Lee commented May 13, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.13%. Comparing base (991faba) to head (09f401a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
gcsfs/extended_gcsfs.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
+ Coverage   88.52%   89.13%   +0.61%     
==========================================
  Files          15       15              
  Lines        2989     3130     +141     
==========================================
+ Hits         2646     2790     +144     
+ Misses        343      340       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread gcsfs/extended_gcsfs.py Outdated
@Yonghui-Lee Yonghui-Lee force-pushed the cache-unknown-buckets-pure branch from 6adac07 to 65c0c9b Compare May 13, 2026 07:50
@ankitaluthra1
Copy link
Copy Markdown
Collaborator

Not caching UNKNOWN type is intentional, since the storage_lookup api should work on every bucket. In case bucket type is UNKNOWN it surely is a transient error and should not be cached. I think we should revert caching UNKNOWN in this PR and can update the documentation instead so its clearer that its an intentional change

Comment thread gcsfs/extended_gcsfs.py Outdated
@Yonghui-Lee Yonghui-Lee force-pushed the cache-unknown-buckets-pure branch from 65c0c9b to 09f401a Compare May 26, 2026 02:48
@Yonghui-Lee Yonghui-Lee changed the title Add option to cache unknown bucket type Document intentional non-caching and fallback behavior for UNKNOWN bucket layouts May 26, 2026
@zhixiangli zhixiangli merged commit afcf7a4 into fsspec:main May 26, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants