Skip to content

Fix BigQuery ingestion errors and improve Cloud Build robustness#849

Merged
zhixiangli merged 1 commit into
fsspec:mainfrom
ankitaluthra1:benchmark-improvements
May 26, 2026
Merged

Fix BigQuery ingestion errors and improve Cloud Build robustness#849
zhixiangli merged 1 commit into
fsspec:mainfrom
ankitaluthra1:benchmark-improvements

Conversation

@Mahalaxmibejugam
Copy link
Copy Markdown
Collaborator

This PR fixes BigQuery ingestion failures caused by schema shifts and improves the robustness of the Cloud Build pipelines.

Key Changes:

  • BigQuery Ingestion: Refactored ingest.sql to use dynamic SQL with explicit, alphabetically ordered column lists. This prevents type/count mismatches when schema evolves.
  • Fail-Fast Validations: Added checks for required substitution variables in both benchmarks and ingestion pipelines to prevent wasted resources.
  • Cleanup Fallback: Added TTLs (1h/4h) to OS Login SSH keys in E2E and benchmarks pipelines as a safety fallback.
  • Bug Fix: Fixed a bug in benchmarks-cloudbuild.yaml that added a trailing hyphen to sanitized branch names (e.g., main-).

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.50%. Comparing base (b1fee12) to head (b60efd0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #849   +/-   ##
=======================================
  Coverage   88.50%   88.50%           
=======================================
  Files          15       15           
  Lines        2993     2993           
=======================================
  Hits         2649     2649           
  Misses        344      344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread cloudbuild/benchmarks/ingest.sql
@zhixiangli zhixiangli merged commit 94efa8c into fsspec:main May 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants