Update default value of mrd_pool_size in micro benchmark to None and add pool parameters to benchmark schema#850
Merged
Conversation
Collaborator
Yonghui-Lee
commented
May 27, 2026
- The read microbenchmarks were previously defaulting mrd_pool_size to 1. It will overrode the environment's DEFAULT_GCSFS_CONCURRENCY and forced the use of only a single gRPC stream. I have changed the default to None, allowing it to correctly inherit environment concurrency settings and restore multi-stream gRPC read performance with the default config.
- Updates the BigQuery staging schema definition to declare both mrd_pool_cache_size and mrd_pool_size as STRING fields. This allows the ingestion pipeline to gracefully parse new results.
…add pool parameters to benchmark schema
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 15 15
Lines 3130 3130
=======================================
Hits 2790 2790
Misses 340 340 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhixiangli
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.