Skip to content

refactor(#1148): join Claude command parts#1202

Open
GHX5T-SOL wants to merge 1 commit into
fullsend-ai:mainfrom
GHX5T-SOL:refactor-1148-claude-command-spacing
Open

refactor(#1148): join Claude command parts#1202
GHX5T-SOL wants to merge 1 commit into
fullsend-ai:mainfrom
GHX5T-SOL:refactor-1148-claude-command-spacing

Conversation

@GHX5T-SOL
Copy link
Copy Markdown

Summary

  • Build the Claude CLI invocation from explicit command parts joined with single spaces.
  • Remove the convention where optional flag fragments have to carry trailing spaces.
  • Add regression tests for all optional flags and no optional flags to catch missing or doubled separators around --agent.

Closes #1148

Validation

  • go test ./internal/cli -run 'TestBuildClaudeCommand'\n- go test ./internal/cli\n- go vet ./internal/cli\n- go test ./...\n- git diff --check\n- git diff | gitleaks stdin --no-banner --redact --timeout 30\n\nLint limitation: make lint failed locally because pre-commit is not installed on this host. I also tried uv run --with pre-commit python -m pre_commit run; it initialized hooks but failed before completing because the lint-md-links hook requires the lychee executable, which is not installed locally.\n

@fullsend-ai-review
Copy link
Copy Markdown

Review

Findings

No findings.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label May 19, 2026
@github-actions
Copy link
Copy Markdown

Site preview

Preview: https://e5f0bc2a-site.fullsend-ai.workers.dev

Commit: 5fe0cafffa9f6d4c754b9babb6182227bb94d0bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buildClaudeCommand: replace trailing-space flag convention with explicit separators

1 participant