feat(skills): add /topissues slash command for RICE backlog by ifireball · Pull Request #1232 · fullsend-ai/fullsend

ifireball · 2026-05-20T07:03:00Z

Summary

Add /topissues slash command (Cursor + Claude Code) backed by a stdlib Python script that builds a merged RICE priority table via gh GraphQL
Introduce canonical commands/ tree with .cursor/commands and .claude/commands symlinks (mirrors existing skills layout)
Wire unit tests into make script-test the same way as process-fix-result-test.py

Test plan

python3 skills/topissues/scripts/topissues_test.py
make script-test (full suite)
Manual: python3 skills/topissues/scripts/topissues.py in a repo with RICE-scored issues
Confirm /topissues appears in Cursor and Claude Code command help

Made with Cursor

Add a stdlib Python script and portable slash command that merges top unassigned backlog issues with the caller's assigned work via gh GraphQL. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-05-20T07:04:32Z

Site preview

Preview: https://1cd25e21-site.fullsend-ai.workers.dev

Commit: 7112d857f2e501b19286093d6318d4fc452e0701

fullsend-ai-review · 2026-05-20T07:09:07Z

Review

Findings

High

[protected-path] .claude/commands — This PR adds a symlink under .claude/, which is a protected path requiring human approval. The PR has no linked issue (closingIssuesReferences is empty) and the description does not reference an authorizing issue. While the symlink mirrors the existing .claude/skills -> ../skills pattern and the rationale is clear from context, protected-path changes require a linked issue for traceability.
Remediation: Link a GitHub issue authorizing the .claude/commands symlink addition, or have a maintainer explicitly approve the protected-path change.

Previous run

Review

Findings

High

[protected-path] .claude/commands — This PR adds a symlink under .claude/, which is a protected path requiring human approval. The PR has no linked issue (closingIssuesReferences is empty) and the description does not reference an authorizing issue. While the symlink mirrors the existing .claude/skills -> ../skills pattern and the rationale is clear from context, protected-path changes require a linked issue for traceability.
Remediation: Link a GitHub issue authorizing the .claude/commands symlink addition, or have a maintainer explicitly approve the protected-path change.

Prior review note: the low-severity [correctness] finding from the previous review (re resolve_project_number env-var parsing without try/except ValueError) is resolved — the code now correctly wraps int(env_val) in try/except ValueError (lines 407–410).

Previous run (2)

Review

Findings

High

[protected-path] .claude/commands — This PR adds a symlink under .claude/, which is a protected path requiring human approval. The PR has no linked issue (closingIssuesReferences is empty) and the description does not reference an authorizing issue. While the symlink mirrors the existing .claude/skills -> ../skills pattern and the rationale is clear from context, protected-path changes require a linked issue for traceability.
Remediation: Link a GitHub issue authorizing the .claude/commands symlink addition, or have a maintainer explicitly approve the protected-path change.

Low

[correctness] skills/topissues/scripts/topissues.py:390 — resolve_project_number parses the FULLSEND_PROJECT_NUMBER environment variable with a bare int(env_val) call (no try/except ValueError). If the env var is set to a non-numeric string (e.g. "abc"), the script raises an unhandled ValueError with a raw traceback instead of the friendly error message at the end of the function. The try_run_gh fallback path just below correctly wraps int() in try/except ValueError, but the env-var path does not.
Remediation: Wrap the int(env_val) call in a try/except ValueError block that falls through to the friendly error message, matching the pattern used for the org-variable fallback.

Prior review note: the medium-severity [correctness] finding from the previous review (re resolve_project_number using run_gh) is resolved — the code now correctly uses try_run_gh, which returns None on failure and allows the friendly error message to be reached.

Previous run (3)

Review

Findings

High

[protected-path] .claude/commands — This PR adds a symlink under .claude/, which is a protected path requiring human approval. The PR has no linked issue (closingIssuesReferences is empty) and the description does not reference an authorizing issue. While the symlink mirrors the existing .claude/skills -> ../skills pattern and the rationale is clear from context, protected-path changes require a linked issue for traceability.
Remediation: Link a GitHub issue authorizing the .claude/commands symlink addition, or have a maintainer explicitly approve the protected-path change.

Medium

[correctness] skills/topissues/scripts/topissues.py:388 — resolve_project_number attempts to fall through gracefully when gh variable get fails (lines 388–395), but run_gh calls sys.exit(3) on CalledProcessError instead of raising. SystemExit is not caught by except (subprocess.CalledProcessError, ValueError), so the friendly error message at lines 396–401 ("project number required; set FULLSEND_PROJECT_NUMBER…") is unreachable when the gh command fails. Users who lack the org variable get a raw gh CLI error (exit 3) instead of the intended guidance listing all three ways to provide the project number.
Remediation: Use subprocess.run directly (without run_gh) for this call so CalledProcessError can be caught, or add a check=False variant of run_gh that returns the result instead of exiting.

Previous run (4)

Review

Findings

High

[protected-path] .claude/commands — This PR adds a symlink under .claude/, which is a protected path requiring human approval. The PR has no linked issue (closingIssuesReferences is empty) and the description does not reference an authorizing issue. While the symlink mirrors the existing .claude/skills -> ../skills pattern and the rationale is clear from context, protected-path changes require a linked issue for traceability.
Remediation: Link a GitHub issue authorizing the .claude/commands symlink addition, or have a maintainer explicitly approve the protected-path change.

Info

[correctness] skills/topissues/scripts/topissues.py:31 — The ISSUES_QUERY fetches comments(first: 100) as a nested connection without pagination. Issues with more than 100 comments may have their RICE score comment missed if it falls outside the first 100. This is a practical limitation unlikely to matter for most repositories.
Remediation: Consider paginating comments or fetching them in reverse chronological order (most recent RICE score is likely near the end).

Previous run (5)

Review

Findings

High

[protected-path] .claude/commands — This PR adds a symlink under .claude/, which is a protected path requiring human approval. The PR has no linked issue to authorize the change. While the symlink mirrors the existing .claude/skills -> ../skills pattern and the PR description explains the rationale, protected-path changes require a linked issue for traceability. Human review is required before merging.
Remediation: Link a GitHub issue authorizing the .claude/commands symlink addition, or have a maintainer explicitly approve the protected-path change.

Low

[correctness] skills/topissues/scripts/topissues.py:76 — The RICE_SCORE_RE regex uses [\\d.]+ which can match invalid float strings like 1.2.3 or .... If such a string appears in a comment, float(match.group(1)) will raise an unhandled ValueError. While RICE scores are agent-generated and unlikely to be malformed, defensive parsing would be more robust.
Remediation: Wrap the float() call in a try/except ValueError, or tighten the regex to \\d+(?:\\.\\d+)?.

Info

[correctness] skills/topissues/scripts/topissues.py:31 — The GraphQL query fetches comments(first: 100) without pagination. Issues with more than 100 comments may have their RICE score comments truncated, causing the script to miss or undercount scores. This is a practical limitation unlikely to matter for most repositories.
Remediation: Consider paginating comments or fetching them in reverse chronological order (most recent RICE score is likely near the end).

fullsend-ai-review

See the review comment for full details.

Use a stricter float pattern and skip malformed matches so invalid agent comment text cannot crash the script. Co-authored-by: Cursor <cursoragent@cursor.com>

ifireball · 2026-05-20T07:13:50Z

Maintainer sign-off (@ifireball)

Protected-path (/.claude/commands): Approved on behalf of maintainers. This mirrors the existing .claude/skills → ../skills symlink pattern; the canonical commands/ tree is required for portable /topissues in Cursor and Claude Code.

Review agent findings:

RICE regex (low): Fixed in decf4df5 — see thread reply.
Comment pagination (info): Accepted v1 limitation — see thread reply.

(GitHub blocks self-approval on own PRs; this comment is explicit maintainer authorization for the protected-path change.)

fullsend-ai-review

See the review comment for full details.

Stop parsing issue comments; use the org project board RICE Score field (the same source post-prioritize.sh writes). Add --project and project resolution via FULLSEND_PROJECT_NUMBER. Co-authored-by: Cursor <cursoragent@cursor.com>

ifireball · 2026-05-20T10:48:16Z

Pushed 7f786811: /topissues now reads RICE Score from the org GitHub Project board only (no issue comments). Adds --project N and resolves project number from FULLSEND_PROJECT_NUMBER env or org variable.

Assert normalize_project_item result is non-None before subscripting. Co-authored-by: Cursor <cursoragent@cursor.com>

fullsend-ai-review

See the review comment for full details.

Use try_run_gh for FULLSEND_PROJECT_NUMBER resolution so a missing org variable reaches the friendly error instead of exiting via run_gh. Co-authored-by: Cursor <cursoragent@cursor.com>

fullsend-ai-review

See the review comment for full details.

Fall through to the friendly project-number error when the env var is set but not a valid integer. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

fullsend-ai-review

See the review comment for full details.

ifireball · 2026-05-25T08:08:54Z

@ralphbean since you marked your review comments as low quality, should I regard that as a signal to ignore them and go ahead and merge the PR ?

Read GitHub issue blocking relationships instead of labels so backlog items like fullsend-ai#470 (blocked by open fullsend-ai#788) are omitted from top-scored work. Co-authored-by: Cursor <cursoragent@cursor.com>

fullsend-ai-review

See the review comment for full details.

feat(skills): add /topissues slash command for RICE backlog

f75853c

Add a stdlib Python script and portable slash command that merges top unassigned backlog issues with the caller's assigned work via gh GraphQL. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions Bot deployed to site-preview May 20, 2026 07:04 View deployment

fullsend-ai-review Bot suggested changes May 20, 2026

View reviewed changes

Comment thread skills/topissues/scripts/topissues.py Outdated

Comment thread skills/topissues/scripts/topissues.py

ifireball self-assigned this May 20, 2026

fix(topissues): tighten RICE score regex parsing

decf4df

Use a stricter float pattern and skip malformed matches so invalid agent comment text cannot crash the script. Co-authored-by: Cursor <cursoragent@cursor.com>

ifireball marked this pull request as ready for review May 20, 2026 07:13

github-actions Bot deployed to site-preview May 20, 2026 07:14 View deployment

fullsend-ai-review Bot suggested changes May 20, 2026

View reviewed changes

Comment thread skills/topissues/scripts/topissues.py

ifireball requested review from ascerra, ralphbean and rh-hemartin May 20, 2026 09:02

rh-hemartin approved these changes May 20, 2026

View reviewed changes

github-actions Bot deployed to site-preview May 20, 2026 10:49 View deployment

fix(topissues): satisfy ty check in project item test

a6edf79

Assert normalize_project_item result is non-None before subscripting. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions Bot deployed to site-preview May 20, 2026 10:52 View deployment

fullsend-ai-review Bot suggested changes May 20, 2026

View reviewed changes

Comment thread skills/topissues/scripts/topissues.py Outdated

fix(topissues): make org variable lookup failure fall through

cb95b78

Use try_run_gh for FULLSEND_PROJECT_NUMBER resolution so a missing org variable reaches the friendly error instead of exiting via run_gh. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions Bot deployed to site-preview May 20, 2026 13:35 View deployment

fullsend-ai-review Bot suggested changes May 20, 2026

View reviewed changes

Comment thread skills/topissues/scripts/topissues.py

fix(topissues): handle non-numeric FULLSEND_PROJECT_NUMBER env

c8e22e5

Fall through to the friendly project-number error when the env var is set but not a valid integer. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions Bot deployed to site-preview May 20, 2026 13:52 View deployment

style(topissues): combine nested with statements for ruff SIM117

35a5441

Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions Bot deployed to site-preview May 20, 2026 13:55 View deployment

fullsend-ai-review Bot suggested changes May 20, 2026

View reviewed changes

This comment was marked as low quality.

Sign in to view

fix(topissues): exclude issues with open blockedBy links from top pool

7112d85

Read GitHub issue blocking relationships instead of labels so backlog items like fullsend-ai#470 (blocked by open fullsend-ai#788) are omitted from top-scored work. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions Bot deployed to site-preview May 25, 2026 17:13 View deployment

fullsend-ai-review Bot suggested changes May 25, 2026

View reviewed changes

Conversation

ifireball commented May 20, 2026

Summary

Test plan

Uh oh!

github-actions Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Site preview

Uh oh!

fullsend-ai-review Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review

Findings

High

Review

Findings

High

Review

Findings

High

Low

Review

Findings

High

Medium

Review

Findings

High

Info

Review

Findings

High

Low

Info

Uh oh!

fullsend-ai-review Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ifireball commented May 20, 2026

Maintainer sign-off (@ifireball)

Uh oh!

fullsend-ai-review Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ifireball commented May 20, 2026

Uh oh!

fullsend-ai-review Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fullsend-ai-review Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fullsend-ai-review Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as low quality.

Uh oh!

This comment was marked as low quality.

Uh oh!

ifireball commented May 25, 2026

Uh oh!

fullsend-ai-review Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented May 20, 2026 •

edited

Loading

fullsend-ai-review Bot commented May 20, 2026 •

edited

Loading