fix(install): verify app installations when using --skip-app-setup#1267
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(install): verify app installations when using --skip-app-setup#1267fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The --skip-app-setup flag trusted that shared apps were already installed but never verified it. Missing apps caused a cryptic 502 at runtime from the mint. Now the installer checks ListOrgInstallations and emits a clear error naming each missing app with its installation URL. Also improves the mint's error response: when installation lookup returns 404, the mint now returns 422 with a descriptive detail field instead of a generic 502. Closes #1266 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Site previewPreview: https://f70d6ac3-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. Clean, well-scoped fix that addresses both sides of #1266: fail-fast validation in the installer and improved error responses from the mint. The |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
Contributor
|
Do normal users have permissions to run this? @ralphbean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --skip-app-setup flag trusted that shared apps were already installed but never verified it. Missing apps caused a cryptic 502 at runtime from the mint. Now the installer checks ListOrgInstallations and emits a clear error naming each missing app with its installation URL.
Also improves the mint's error response: when installation lookup returns 404, the mint now returns 422 with a descriptive detail field instead of a generic 502.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Closes #1266
Post-script verification
fullsend/code/issue-1266)7d641173d1c258a1a7e3bcb087cb481576eabb45..HEAD)