fix(engine): default channel cascade to managed chromium, not system chrome#65
Merged
Conversation
…chrome The 0.1.50 cascade preferred channel=chrome (system Google Chrome). On some Linux servers the system chrome binary launches fine but has no network route (ERR_INTERNET_DISCONNECTED) — proven on a real host where channel=chrome fails on every navigation while the managed Chrome-for-Testing (channel=chromium) and the bundled shell both return 200. The cascade cannot recover from this: it only falls through on a missing-binary launch error, not a runtime navigation failure, so it served a network-dead browser. Default cascade is now [chromium, undefined]: the Playwright-managed full Chromium build (new headless, no HeadlessChrome in sec-ch-ua, real WebGL — same high-signal stealth, only the brand reads Chromium instead of Google Chrome) then the bundled shell. System chrome/msedge are opt-in via explicit channel. Exposes channel:"chromium" in the type + Zod enum and documents the tradeoff in the channel description so agents pick correctly (omit = safe default). Verified: macOS default stays clean (no HeadlessChrome, webdriver false, sec-ch-ua Chromium), the broken host now reaches Google. tsc clean, 194 unit + 20 integration green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (reproduit sur serveur réel — hermes)
La cascade 0.1.50 préférait
channel:chrome(Google Chrome système). Sur certains serveurs Linux, ce binaire se lance mais n'a aucune route réseau →ERR_INTERNET_DISCONNECTEDsur toute navigation. La cascade ne peut pas récupérer : elle ne retombe que sur une erreur de binaire absent (launch), pas sur un échec runtime de navigation → elle servait un browser sans réseau.Preuve hôte réel :
channel:chrome→ -106 partout ;channel:chromium(Chrome-for-Testing géré) → 200 ; bundlé → 200.Fix
Cascade par défaut
[chromium, undefined]: le Chromium géré (new headless, pas de HeadlessChrome dans sec-ch-ua, WebGL réel — même furtivité haut-signal, la marque passe juste deGoogle ChromeàChromium) puis le shell bundlé.chrome/msedge*deviennent opt-in viachannelexplicite.channel:"chromium"est désormais sélectionnable (type + schéma) avec une description qui guide l'agent (omettre = défaut sûr).Validation