Skip to content

v1.60.2.0 fix: make ship handoffs self-contained#2303

Open
fedster99 wants to merge 3 commits into
garrytan:mainfrom
fedster99:fedster99/ship-context-handoff
Open

v1.60.2.0 fix: make ship handoffs self-contained#2303
fedster99 wants to merge 3 commits into
garrytan:mainfrom
fedster99:fedster99/ship-context-handoff

Conversation

@fedster99

@fedster99 fedster99 commented Jul 19, 2026

Copy link
Copy Markdown

Summary

Ship workflow

  • Makes every /ship completion report self-contained: it now opens with What this work was about, naming the product or feature, prior behavior, motivating problem, and intended outcome before the engineering summary.
  • Requires the final Put simply explanation to name its concrete subject instead of depending on context-free pronouns.
  • Preserves the full engineering handoff and UI evidence gate across the source template, generated skill, and Claude/Codex/Factory golden fixtures.

Installer runtime packaging

  • Links or copies the shared lib/ directory beside bin/ for agent sidecars, Codex, Factory, OpenCode, and Kiro, so command scripts can resolve their existing relative imports.

Test Coverage

All changed behavior is regression-covered across the source template, generated artifacts, golden host fixtures, and all five affected install paths.

  • Focused contract, host, and generator suite: 485 passed, 0 failed.
  • Full repository test command completed with exit 0 on Bun 1.3.14; branch-specific suites passed. Untouched machine-dependent suites still print known local environment failures for missing full Xcode/XCTest and isolated gbrain/jq assumptions.
  • Full build passed.
  • All generated host artifacts pass the freshness check.

Pre-Landing Review

No issues found.

Design Review

No frontend files changed — design review skipped.

Eval Results

The diff selector chose the ship and journey behavior evals. The detached run completed with 46 passed, 318 skipped, and 21 environment failures: the Anthropic SDK has no API credential, Gemini exhausted its quota, and this machine has only Command Line Tools rather than full Xcode/XCTest. The selected agent runs therefore returned error_api or provider-quota errors instead of behavioral verdicts; deterministic prompt-contract tests passed.

Scope Drift

Scope Check: CLEAN. The branch contains the intended ship-handoff contract and the pending installer runtime-completeness fix, plus their tests and generated artifacts.

Plan Completion

No plan file detected.

TODOS

No TODO items completed in this PR.

Documentation

  • Updated CHANGELOG.md with the user-facing handoff and installer behavior.
  • No README or architecture changes were needed; this changes an existing workflow contract and packaging completeness, not public command syntax or system architecture.

Test plan

  • npx --yes bun@latest test test/ship-completion-report.test.ts test/host-config.test.ts test/gen-skill-docs.test.ts
  • npx --yes bun@latest run test
  • npx --yes bun@latest run build
  • npx --yes bun@latest run scripts/gen-skill-docs.ts --dry-run --host all
  • git diff --check origin/main
  • Credentialed behavior evals (local environment has no Anthropic SDK credential)

🤖 Generated with Codex

@trunk-io

trunk-io Bot commented Jul 19, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@fedster99

Copy link
Copy Markdown
Author

/trunk merge

@trunk-io

trunk-io Bot commented Jul 19, 2026

Copy link
Copy Markdown

An error occurred while submitting your PR to the queue: Only users that are a part of this repo's Trunk organization or have write permissions to the repo can submit a PR to the queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant