v1.60.2.0 fix: make ship handoffs self-contained#2303
Open
fedster99 wants to merge 3 commits into
Open
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Author
|
/trunk merge |
|
An error occurred while submitting your PR to the queue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ship workflow
/shipcompletion report self-contained: it now opens withWhat this work was about, naming the product or feature, prior behavior, motivating problem, and intended outcome before the engineering summary.Put simplyexplanation to name its concrete subject instead of depending on context-free pronouns.Installer runtime packaging
lib/directory besidebin/for agent sidecars, Codex, Factory, OpenCode, and Kiro, so command scripts can resolve their existing relative imports.Test Coverage
All changed behavior is regression-covered across the source template, generated artifacts, golden host fixtures, and all five affected install paths.
Pre-Landing Review
No issues found.
Design Review
No frontend files changed — design review skipped.
Eval Results
The diff selector chose the ship and journey behavior evals. The detached run completed with 46 passed, 318 skipped, and 21 environment failures: the Anthropic SDK has no API credential, Gemini exhausted its quota, and this machine has only Command Line Tools rather than full Xcode/XCTest. The selected agent runs therefore returned
error_apior provider-quota errors instead of behavioral verdicts; deterministic prompt-contract tests passed.Scope Drift
Scope Check: CLEAN. The branch contains the intended ship-handoff contract and the pending installer runtime-completeness fix, plus their tests and generated artifacts.
Plan Completion
No plan file detected.
TODOS
No TODO items completed in this PR.
Documentation
CHANGELOG.mdwith the user-facing handoff and installer behavior.Test plan
npx --yes bun@latest test test/ship-completion-report.test.ts test/host-config.test.ts test/gen-skill-docs.test.tsnpx --yes bun@latest run testnpx --yes bun@latest run buildnpx --yes bun@latest run scripts/gen-skill-docs.ts --dry-run --host allgit diff --check origin/main🤖 Generated with Codex