Bring up-to-date, directly call Viz from extension.ts, bump 0.1.0#19
Open
Profpatsch wants to merge 1 commit into
Open
Bring up-to-date, directly call Viz from extension.ts, bump 0.1.0#19Profpatsch wants to merge 1 commit into
Profpatsch wants to merge 1 commit into
Conversation
This simplifies the setup, I assume old versions of vscode still required a lot of workarounds. Move to new Viz library which is a real module, so we can directly call it from `extension.ts` instead of the workaround. This speeds up things considerably, because we don’t have to initialize the wasm library on each call, instead do it once on extension init. The `<pre style="all:unset">` trick is the same as the one used by the preview code generated by the mermaid extension. I removed the test stubs. I moved to npm lockfiles and removed yarn. This bumps the extension version to 0.1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the setup, I assume old versions of vscode still required a lot of workarounds.
Move to new Viz library which is a real module, so we can directly call it from
extension.tsinstead of the workaround. This speeds up things considerably, because we don’t have to initialize the wasm library on each call, instead do it once on extension init.The
<pre style="all:unset">trick is the same as the one used by the preview code generated by the mermaid extension.I removed the test stubs.
I moved to npm lockfiles and removed yarn.
This bumps the extension version to 0.1.0.