Handle max amount swap for chainflip

[0xh3rman]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the Chainflip swapper provider by adding functionality to handle the maximum amount swap and introducing a checklist for swapper provider integrations. It also updates testing configurations to skip integration tests by default.

Highlights

• Max Amount Handling: The PR introduces logic to handle the maximum amount swap for Chainflip, ensuring that the from_value used in the quote request and response is correctly adjusted when use_max_amount is enabled.
• Swapper Checklist: A new Swapper Checklist document was added to guide the auditing of swapper providers, ensuring they adhere to standard integration practices.
• Test Updates: The integration tests are now skipped by default when running tests for a specific crate.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly implements 'max amount' handling for Chainflip swaps by using resolve_max_quote_value and propagating the adjusted from_value through the quote and quote data generation process. The changes are consistent across EVM paths. However, there's a potential oversight that falls outside the changed lines of this PR. In crates/swapper/src/chainflip/provider.rs, within the get_quote_data function, the VaultSwapResponse::Bitcoin match arm still uses quote.request.value instead of quote.from_value. To ensure consistent 'max amount' behavior, this should be updated as well. I've also left a minor suggestion to avoid an unnecessary clone.