Skip to content

refactor(py): clean up top-level genkit python organization#5370

Open
huangjeff5 wants to merge 3 commits into
mainfrom
jh-top-level-cleanup
Open

refactor(py): clean up top-level genkit python organization#5370
huangjeff5 wants to merge 3 commits into
mainfrom
jh-top-level-cleanup

Conversation

@huangjeff5
Copy link
Copy Markdown
Contributor

@huangjeff5 huangjeff5 commented May 21, 2026

While auditing the code base I found more unused stuff in the python repo. Continuing my cleanup. Removes the following:

  • py/tools/schema_to_typing/schema_to_typing.py -> py/bin/schema_to_typing.py
  • Deletes py/tools/ entirely (the only other content was an orphan PNG and a .DS_Store)
  • Updates py/bin/generate_schema_typing to point at the new location
  • drop dead test-runner shims (noxfile.py, tox.ini)
  • drop typos config
  • deleted model_performance_report.md (one-off file)
  • remove poethepoet dev dep (not used)

@huangjeff5 huangjeff5 requested a review from a team May 21, 2026 15:25
@github-actions github-actions Bot added docs Improvements or additions to documentation python Python config labels May 21, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the typos spell checker, nox, and tox configurations, and relocates the schema_to_typing.py script to the bin directory. Feedback points out that the header documentation in check_consistency needs updating to match the new check count and suggests including the relocated generator script in the linting process.

Comment thread py/bin/check_consistency
Comment thread py/pyproject.toml Outdated
@huangjeff5 huangjeff5 changed the title chore(py): refactor top-level genkit python organization refactor(py): clean up top-level genkit python organization May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config docs Improvements or additions to documentation python Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants