fix(js/ai): correctly tag registered interrupt as a non-dynamic tool#5376
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies the defineInterrupt function to explicitly remove the dynamic metadata flag before registration and adds a test case to verify this behavior. The reviewer suggests refactoring defineInterrupt to use defineTool instead of manual registration to ensure consistency across API versions and reduce code duplication.
|
Can you add interrupts to I think DevUI is going to skip these if it detects any other v2 tools (we assume all are of a single type). |
Hmm... I'm not sure if it's a breaking change to convert to interrupt to a tool.v2... will have to defer that. |
|
I’ll double check, could be mistaken on the logic. I thought even tool (v1)
got wrapped as a tool.v2 (i.e duplicated) though. In fact, I think gemini
pointed that out to me when I reviewed this PR.
…On Fri, May 22, 2026 at 9:35 PM Pavel Jbanov ***@***.***> wrote:
Merged #5376 <#5376> into main.
—
Reply to this email directly, view it on GitHub
<#5376 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVZ2UR4IQAJ4XRDXRHRGYD44D545AVCNFSM6AAAAACZICFDPSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRVHA3TIMBTHE3TONQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
No description provided.