Fix #11930 Catalog Refactor and integration of Geonode api in the Catalog.#12107
Open
anup39 wants to merge 44 commits intogeosolutions-it:masterfrom
Open
Fix #11930 Catalog Refactor and integration of Geonode api in the Catalog.#12107anup39 wants to merge 44 commits intogeosolutions-it:masterfrom
anup39 wants to merge 44 commits intogeosolutions-it:masterfrom
Conversation
Fix catalog mock refactor 1
…x_catalog_mock_refactor
5 tasks
…atalog advance settings
dsuren1
requested changes
Apr 15, 2026
Contributor
There was a problem hiding this comment.
@anup39
Could you kindly address these comments
- Without a border shadow, it becomes difficult to distinguish the elements
Grid

Panel

- When a GFI is triggered while the catalog panel is open, the GFI panel should take precedence

- There seems to be a noticeable performance impact, with the component rendering indefinitely. This may need some investigation. Repro: keep the catalog open, add a layer, and perform another operation (e.g., GFI). (assigned to @dsuren1 )
- Map layout panel dimension is not updated. Open
catalog -> grid view -> close catalog panel -> Now open catalog panel from sidebar

- The map zoom to extent of the latest layer when more than one is selected. Should we instead zoom to collective extent of the layers added? @allyoucanmap
- When
Sort Byfield value is added and then removed, if the value added is still persisted. In case of invalid value, the error restricts the service from being saved. (Sporadic)

- Filtered result is incorrect (assigned to @dsuren1 ) (Not an issue, caused by not having request configuration rules resulting in filtered result from geoserver)

- Select all -> Add to Map -> Impacts performance (Need to verify if it's due to point 3 mentioned above)
- We need to disable
Add To Mapwhen adding the layer map process in progress

Updated (831f6d5)
- Facet param updated with resource type
dataset - Catalog plugin supports configuring fields for the
filterFormFieldsvia localConfig - Context now supports new Catalog plugin (config updated) and overriding of filter form fields. Included backward compatibility
api-presetconfiguration via exposed function from GeoNodeUtils and fallback mechanism usinginclude&excludeparams- Default preset updated to support keyword and category for tag support/display on Resource card
- The Dashboard Editor uses
serviceFiltersto override CatalogstaticTabsandfilterFormFields, in line with other Catalog plugin props. Would it make sense to revisit the prop name for better clarity? @allyoucanmap - MapEditor configuration already support plugin override and it supports Catalog configs too (Verified). So both Dashboard and Geostory using MapEditor can support overriding
Note
Unit tests needs updating
| @@ -0,0 +1,266 @@ | |||
|
|
|||
| .ms-catalog-wrapper { | |||
Contributor
There was a problem hiding this comment.
Could we follow the existing styling pattern instead of adding new CSS? Perhaps this can be moved under the theme less
Contributor
| const ButtonWithTooltip = tooltip(Button); | ||
|
|
||
|
|
||
| const Catalog = ({ |
Contributor
There was a problem hiding this comment.
Kindly include an inline jsdoc comment explaining the plugin configurations support
| import { defaultProps } from 'recompose'; | ||
|
|
||
| import CompactCatalog from '../../components/catalog/CompactCatalog'; | ||
| // import CompactCatalog from '../../components/catalog/CompactCatalog'; |
Contributor
There was a problem hiding this comment.
Suggested change
| // import CompactCatalog from '../../components/catalog/CompactCatalog'; |
| import API from '../../../../api/catalog'; | ||
| import { buildServiceUrl } from '../../../../utils/CatalogUtils'; | ||
|
|
||
| const catalogRequestsWorkflow = (Component) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| const catalogRequestsWorkflow = (Component) => { | |
| const withCatalogRequests = (Component) => { |
Would it make sense to rename the HOC to follow the with convention?
| @@ -0,0 +1,267 @@ | |||
| /* | |||
| * Copyright 2025, GeoSolutions Sas. | |||
Contributor
There was a problem hiding this comment.
Kindly ensure all newly added file to have the correct copyright year
Suggested change
| * Copyright 2025, GeoSolutions Sas. | |
| * Copyright 2026, GeoSolutions Sas. |
…log_refactor_genode_int_11930 * commit 'de55770d13eb703b5b6cfe31ae55f38fea0b9fcf': Fix geosolutions-it#12146: ArcGIS support for FeatureService (geosolutions-it#12235) geosolutions-it#12094: Fix dropdown menu overflow when adding links to text widget in TextEditor (geosolutions-it#12260) geosolutions-it#12207: Fix - ScaleBox plugin - Custom scales not reported on map load (geosolutions-it#12212) fix a few danish translations (geosolutions-it#12230) geosolutions-it#12223: fix rule manager field filtering with checkbox is not working properly (geosolutions-it#12224) geosolutions-it#12218: fix pagination in rules manager layers autocomplete does not work (geosolutions-it#12219) Fix geosolutions-it#12213 - Fixed startup script for java new versions (geosolutions-it#12214) Update Changelog for version 2025.02.03 (geosolutions-it#12211) Fix pre-release gh action workflow for CLA (geosolutions-it#12205) Update Changelog for version 2026.01.00 (geosolutions-it#12202) fix geosolutions-it#12162 flatgeobuf params by getRequestConfigurationByUrl (geosolutions-it#12200) Fix geosolutions-it#12162 COG and FlatGeobuf layers support params for protected storage (geosolutions-it#12179) Fix doc of MapImport plugin (geosolutions-it#12197) Fix geosolutions-it#12044: fix wfs layer hidden in 3D + scale arrow not rendering (geosolutions-it#12155)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds followings:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#11930
What is the new behavior?
Now Catalog plugin has been refactored with followings changes :
Some of the screenshots :
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information