#12146: ArcGIS support for FeatureService#12235
#12146: ArcGIS support for FeatureService#12235anup39 merged 2 commits intogeosolutions-it:masterfrom
Conversation
| return null; | ||
| }; | ||
|
|
||
| const extentToBoundingBox4326 = (extent) => { |
There was a problem hiding this comment.
Hi @dsuren1, I had a question regarding the two functions extentToBoundingBox and extentToBoundingBox4326.
Do we need both of them?
From what I can see, extentToBoundingBox4326 handles reprojection more robustly (including WKT and fallback cases). It might make sense to consolidate to a single implementation to avoid duplication. We could also consider renaming it to extentToBoundingBox if we standardize on this new version considering(replacing) the existing use of extentToBoundingBox.
Let me know your thoughts on this.
Apart from this, everything else looks good to me. Thanks
There was a problem hiding this comment.
This is intentional. While extentToBoundingBox4326 provides more robust reprojection, the two functions differ in output contract, reprojection logic, and error handling. Keeping them separate helps maintain clarity, whereas combining them may introduce a flag and make the behavior less explicit at the call site
|
@ElenaGallo Kindly test this new feature on DEV. Thanks |
…log_refactor_genode_int_11930 * commit 'de55770d13eb703b5b6cfe31ae55f38fea0b9fcf': Fix geosolutions-it#12146: ArcGIS support for FeatureService (geosolutions-it#12235) geosolutions-it#12094: Fix dropdown menu overflow when adding links to text widget in TextEditor (geosolutions-it#12260) geosolutions-it#12207: Fix - ScaleBox plugin - Custom scales not reported on map load (geosolutions-it#12212) fix a few danish translations (geosolutions-it#12230) geosolutions-it#12223: fix rule manager field filtering with checkbox is not working properly (geosolutions-it#12224) geosolutions-it#12218: fix pagination in rules manager layers autocomplete does not work (geosolutions-it#12219) Fix geosolutions-it#12213 - Fixed startup script for java new versions (geosolutions-it#12214) Update Changelog for version 2025.02.03 (geosolutions-it#12211) Fix pre-release gh action workflow for CLA (geosolutions-it#12205) Update Changelog for version 2026.01.00 (geosolutions-it#12202) fix geosolutions-it#12162 flatgeobuf params by getRequestConfigurationByUrl (geosolutions-it#12200) Fix geosolutions-it#12162 COG and FlatGeobuf layers support params for protected storage (geosolutions-it#12179) Fix doc of MapImport plugin (geosolutions-it#12197) Fix geosolutions-it#12044: fix wfs layer hidden in 3D + scale arrow not rendering (geosolutions-it#12155)
Description
This PR adds ArcGIS FeatureService support to MapStore
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
What is the new behavior?
{ "type": "arcgis-feature", "url": "https://services2.arcgis.com/pROHh69WvVijk4nR/ArcGIS/rest/services/GSE_DISTRIBUTORI_STANDARD/FeatureServer", "title": "Title", "visibility": true }Example
Cesium
OL
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
FeatureServer URL below can be used for testing:
https://services2.arcgis.com/pROHh69WvVijk4nR/ArcGIS/rest/services/GSE_DISTRIBUTORI_STANDARD/FeatureServer