Draft
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
renner0e
force-pushed
the
transition-ptyxis-to-konsole
branch
from
9bec048 to
728f4f1
Compare
Member
Author
|
(ignore them being different users :P) before: 
after: 
|
renner0e
force-pushed
the
transition-ptyxis-to-konsole
branch
from
728f4f1 to
19d844e
Compare
You can test this by pinning ptyxis on the panel and then running this script inside `plasma-interactive-console` or upgrade an F43 Aurora image to an image that has this change. It should make Ptyxis disappear and konsole should show up instead, this should make the transition easier as ptyxis won't just vanish with no replacement when we remove it from the image. How this is supposed to work can be read on here. https://develop.kde.org/docs/plasma/scripting/#running-scripts I did not get this working for the favorites section in the kickoff widget, so for that ptyxis will just disappear with no replacement, but at least it will not leave a blank icon behind and will not look as broken. This might annoy a small minority of people that have been running the Beta/Latest stream where ptyxis has been removed already and they have explicitly installed it again via flatpak. This change is intended to reach the Stable stream when we flip the switch on F44 on that. Related: ublue-os/aurora#1741
renner0e
force-pushed
the
transition-ptyxis-to-konsole
branch
from
19d844e to
078dfad
Compare
Member
Author
|
I guess we could also merge this now, it would be a little awkward as the container functionality of konsole will not ever be in F43 |
Member
|
Think we can wait until the stable goes to F44 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: transition users from ptyxis to konsole
You can test this by pinning ptyxis on the panel and then running this
script inside
plasma-interactive-consoleor upgrade an F43 Auroraimage to an image that has this change.
It should make Ptyxis disappear and konsole should show up instead, this
should make the transition easier as ptyxis won't just vanish with no
replacement when we remove it from the image.
How this is supposed to work can be read on here.
https://develop.kde.org/docs/plasma/scripting/#running-scripts
I did not get this working for the favorites section in the kickoff
widget, so for that ptyxis will just disappear with no replacement, but
at least it will not leave a blank icon behind and will not look as
broken.
This might annoy a small minority of people that have been running the
Beta/Latest stream where ptyxis has been removed already and they have
explicitly installed it again via flatpak. This change is intended to
reach the Stable stream when we flip the switch on F44 on that.
Related: ublue-os/aurora#1741