Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Windows on ARM64 support to the Windows installer/build pipeline by producing ARM64-specific service/Wintun artifacts and updating the Inno Setup installer to run on ARM64 and register the correct service binary.
Changes:
- Allow the installer to run on ARM64 and choose an ARM64 service executable when present.
- Extend the Makefile to build/copy
lanternsvc.exefor both amd64 and arm64 into the Windows release layout. - Download/package Wintun DLLs for both amd64 and arm64.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
windows/packaging/exe/inno_setup.iss |
Enables ARM64 installs and dynamically selects the service binary path (ARM64 vs amd64). |
Makefile |
Builds and stages ARM64 Windows service + Wintun alongside existing amd64 artifacts for packaging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/getlantern/engineering/issues/3043