fix(error-reporting): silence ValidationError from user input - #1430
Open
sentry[bot] wants to merge 2 commits into
Open
fix(error-reporting): silence ValidationError from user input#1430sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses CLI-1HQ, where
ValidationErrors resulting from malformed user input (e.g., empty issue identifiers passed by AI agents) were being captured by Sentry, leading to noise.The night-shift triage concluded that these errors should be silenced as they represent expected user-input noise rather than actionable CLI bugs. This aligns with the rationale for silencing other user-facing errors like
OutputErrorandAuthError.Changes:
"validation_error"to theSilenceReasontype insrc/lib/error-reporting.ts.classifySilenced()to return"validation_error"whenerror instanceof ValidationError.test/lib/error-reporting.test.tsto reflect thatValidationErrors are now silenced, rather than captured. Specifically, tests assertingValidationErrors are not silenced were removed, and integration tests forreportCliErrornow verify thatValidationErrors are not captured and instead emit acli.error.silencedmetric.Fixes CLI-1HQ
This PR was automatically generated by Sentry. You can adjust this setting at any time.