fix(telemetry): silence ConfigError for missing DSN - #1431
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR silences
ConfigErrorin the CLI's error-reporting layer. Previously,ConfigErrors, primarily triggered by AI agents (like Codex) attempting to usesentry send-eventwithout a DSN configured, were being reported to Sentry telemetry as issues.Root Cause (CLI-28M):
ConfigErrorindicates a user misconfiguration (no DSN provided via--dsnflag orSENTRY_DSNenvironment variable). This is an expected and handled error condition, not a bug in the CLI itself. However, it was not explicitly listed in theclassifySilenced()function, leading to unnecessary noise in telemetry.Solution:
ConfigErrorto theSilenceReasontype.ConfigErrorintopackages/cli/src/lib/error-reporting.ts.classifySilenced()to return'config_error'when aninstanceof ConfigErroris encountered. This ensures these expected user-misconfiguration errors are no longer reported as Sentry issues, while still being tracked by thecli.error.silencedmetric.packages/cli/test/lib/error-reporting.test.tsto reflect this change, movingConfigErrorfrom the 'does NOT silence' group to a dedicated test asserting it is now silenced as 'config_error'.Fixes CLI-28M
This PR was automatically generated by Sentry. You can adjust this setting at any time.